Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mage fields to x-pack/libbeat #10346

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

ph
Copy link
Contributor

@ph ph commented Jan 26, 2019

The fields was missing for the x-pack/libbeat build target.

This related to the changed I've made to infra.

The `fields` was missing for the x-pack/libbeat build target.
@ph ph added review needs_backport PR is waiting to be backported to other branches. :Testing labels Jan 26, 2019
@ph ph added in progress Pull request is currently in progress. and removed review labels Jan 26, 2019
@ph
Copy link
Contributor Author

ph commented Jan 26, 2019

Will wait for ci to complete to set reviews since I haven’t run the complete ci

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this.

@ycombinator
Copy link
Contributor

@ph I hope you don't mind me merging this on your behalf. I'm doing it since it will help make master and PR builds go green.

@ycombinator ycombinator merged commit 3f49f61 into elastic:master Jan 26, 2019
ycombinator pushed a commit to ycombinator/beats that referenced this pull request Jan 26, 2019
The `fields` was missing for the x-pack/libbeat build target.

(cherry picked from commit 3f49f61)
@ycombinator ycombinator added v6.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 26, 2019
@ph
Copy link
Contributor Author

ph commented Jan 26, 2019

Thanks @ycombinator

ph pushed a commit that referenced this pull request Jan 26, 2019
The `fields` was missing for the x-pack/libbeat build target.

(cherry picked from commit 3f49f61)
ycombinator pushed a commit to ycombinator/beats that referenced this pull request Jan 26, 2019
The `fields` was missing for the x-pack/libbeat build target.

(cherry picked from commit 3f49f61)
ph pushed a commit that referenced this pull request Jan 26, 2019
The `fields` was missing for the x-pack/libbeat build target.

(cherry picked from commit 3f49f61)
@ph ph added review and removed in progress Pull request is currently in progress. labels Jan 28, 2019
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
The `fields` was missing for the x-pack/libbeat build target.

(cherry picked from commit 181d784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants