Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix port in couchdb module system test #10358

Merged
merged 2 commits into from
Jan 28, 2019
Merged

Fix port in couchdb module system test #10358

merged 2 commits into from
Jan 28, 2019

Conversation

jsoriano
Copy link
Member

No description provided.

@jsoriano jsoriano added module review Metricbeat Metricbeat :Testing Team:Integrations Label for the Integrations team labels Jan 28, 2019
@jsoriano jsoriano self-assigned this Jan 28, 2019
@jsoriano jsoriano requested a review from a team as a code owner January 28, 2019 08:35
@jsoriano jsoriano mentioned this pull request Jan 28, 2019
Merged
ruflin
ruflin approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder why tests were passing before, or does this have to be changed also somewhere else?

@jsoriano
Copy link
Member Author

Test in CI uses the port in the env file, that is correct

But I have also seen running it locally that with an incorrect port it reports the failure, but it is not detected by the test.

@jsoriano
Copy link
Member Author

Added a check to system test to detect reported errors.

@jsoriano jsoriano merged commit 3d58a68 into elastic:master Jan 28, 2019
@jsoriano jsoriano deleted the fix-couchdb-test-port branch January 28, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@jsoriano jsoriano

Labels
Metricbeat Metricbeat module review Team:Integrations Label for the Integrations team :Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoriano @ruflin