Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Change type of field docker.container.ip_addresses to ip instead of keyword #10364

Merged
merged 4 commits into from
Jan 29, 2019
Merged

[Metricbeat] Change type of field docker.container.ip_addresses to ip instead of keyword #10364

merged 4 commits into from
Jan 29, 2019

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Jan 28, 2019 •
edited
Loading

This will make more queries possible then just with keyword.

@ruflin ruflin added module review Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Jan 28, 2019
@ruflin ruflin self-assigned this Jan 28, 2019
@ruflin ruflin requested review from a team as code owners January 28, 2019 11:40
@ruflin
[Metricbeat] Change type of field docker.container.ip_addresses to `i…
38b84df 
…p` instead of `keyword

This will make more queries possible then just with keyword.
@ruflin
commit id
6faa9a0
@ruflin ruflin force-pushed the change-docker-ip-address-change branch from f90a926 to 6faa9a0 Compare January 28, 2019 11:42
@ruflin ruflin changed the title [Metricbeat] Change type of field docker.container.ip_addresses to `i… [Metricbeat] Change type of field docker.container.ip_addresses to ip instead of keyword Jan 28, 2019
sayden
sayden suggested changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG seems to have some unwanted lines

CHANGELOG.next.asciidoc Show resolved Hide resolved
sayden
sayden approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go :) (once the conflict is fixed)

@ruflin ruflin merged commit 941952a into elastic:master Jan 29, 2019
@ruflin ruflin deleted the change-docker-ip-address-change branch January 29, 2019 08:45
@monicasarbu monicasarbu changed the title [Metricbeat] Change type of field docker.container.ip_addresses to ip instead of keyword [Metricbeat] Change type of field docker.container.ip_addresses to ip instead of keyword Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

Assignees

@ruflin ruflin

Labels
Metricbeat Metricbeat module review Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruflin @sayden