Remove dissect tokenizing from Traefik Filebeat Access Fileset #10442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayden
added
enhancement
Metricbeat
|
Pushing to see if it's an issue with my local. I have tested the pipeline successfully in ES6 but I couldn't try with ES7 |
|
jenkins, test this please |
ruflin
reviewed
Jan 31, 2019
| "patterns": [ | ||
| "(?:%{NUMBER:http.response.body.bytes:long}|-)( (?:\"%{DATA:http.request.referrer}\"|-)?( (?:\"%{DATA:traefik.access.agent}\"|-)?)?( (?:%{NUMBER:traefik.access.request_count:long}|-)?)?( (?:\"%{DATA:traefik.access.frontend_name}\"|-)?)?( \"%{DATA:traefik.access.backend_url}\")?( %{NUMBER:temp.duration:long}ms)?)?" | ||
| "%{IPORHOST:source.address} %{GREEDYDATA:traefik.access.user_identifier} %{GREEDYDATA:user.name} \\[%{HTTPDATE:traefik.access.time}\\] \"%{WORD:http.request.method} %{DATA:url.original} HTTP/%{NUMBER:http.version}\" %{NUMBER:http.response.status_code:long} (?:%{NUMBER:http.response.body.bytes:long}|-)?( (?:\"%{DATA:http.request.referrer}\"|-)? (?:\"%{DATA:traefik.access.agent}\"|-)? (?:%{NUMBER:traefik.access.request_count:long}|-)? (?:\"%{DATA:traefik.access.frontend_name}\"|-)? (?:\"%{DATA:traefik.access.backend_url}\"|-)?( %{NUMBER:temp.duration:long}ms|-)?)?" |
There was a problem hiding this comment.
We should use the dissect processor here as we did in Filebeat for the first part: https://www.elastic.co/guide/en/elasticsearch/reference/master/dissect-processor.html It's more efficient then grok.
There was a problem hiding this comment.
Ok, fixed adding a dissect processor at the top of the pipeline
sayden
force-pushed
the
feature/fb/remove-config-pipelining-from-traefik
branch
from
24c3d9f
to
dd35952
Compare
|
jenkins, test this please |
ruflin
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #9434
I had a problem as I couldn't make it work with ES7 and I struggling to make it work in ES6 because in ES6 we use
intas type for many Grok patterns but in ES7 we uselong. It seems thatlongis detected as astringin ES6 and it was giving many troubles.The problem trying to test this in ES7 is that it just gets frozen and, reviewing logs the only clue is a message saying:
Malformed [mappings] section for type [date_detection], should include an inner object describing the mapping