Fix missing nodes from Node Listing page when using Metricbeat Elasticsearch module with xpack.enabled: true #10639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
bug
review
Metricbeat
|
Pinging @elastic/stack-monitoring |
ycombinator
added
the
needs_backport
|
Do we know which released versions this bug affected? |
|
jenkins, test this |
Looking at past branches, it appears that 6.6.0 was where this bug was introduced. |
|
@ycombinator K. I'm just thinking about what we might be able to do to raise awareness for people who run into this bug that it's a known issue and that it's since been fixed. Maybe it's worth at least filing a corresponding issue that people can search for? |
ycombinator
changed the title
|
@cachedout I renamed this PR title to be more about the problem. That way if a user searches for any of those words, this PR should turn up in their results. |
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
|
@ruflin I'd like you to review this, when you get a chance, please. Thank you! |
ruflin
approved these changes
Feb 11, 2019
ycombinator
added a commit
to ycombinator/beats
that referenced
this pull request
Feb 11, 2019
…csearch module with xpack.enabled: true (elastic#10639) * Add source_node object to node_stats documents * Adding CHANGELOG entry (cherry picked from commit 6ddaae6)
ycombinator
removed
the
needs_backport
ycombinator
added a commit
to ycombinator/beats
that referenced
this pull request
Feb 11, 2019
…csearch module with xpack.enabled: true (elastic#10639) * Add source_node object to node_stats documents * Adding CHANGELOG entry (cherry picked from commit 6ddaae6)
ycombinator
added a commit
to ycombinator/beats
that referenced
this pull request
Feb 11, 2019
…csearch module with xpack.enabled: true (elastic#10639) * Add source_node object to node_stats documents * Adding CHANGELOG entry (cherry picked from commit 6ddaae6)
ycombinator
added a commit
that referenced
this pull request
Feb 12, 2019
…hen using Metricbeat Elasticsearch module with xpack.enabled: true (#10673) * Fix missing nodes from Node Listing page when using Metricbeat Elasticsearch module with xpack.enabled: true (#10639) * Add source_node object to node_stats documents * Adding CHANGELOG entry (cherry picked from commit 6ddaae6) * Removing extraneous changes
ycombinator
added a commit
to ycombinator/beats
that referenced
this pull request
Feb 12, 2019
…csearch module with xpack.enabled: true (elastic#10639) * Add source_node object to node_stats documents * Adding CHANGELOG entry (cherry picked from commit 6ddaae6)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… page when using Metricbeat Elasticsearch module with xpack.enabled: true (elastic#10673) * Fix missing nodes from Node Listing page when using Metricbeat Elasticsearch module with xpack.enabled: true (elastic#10639) * Add source_node object to node_stats documents * Adding CHANGELOG entry (cherry picked from commit 9619718) * Removing extraneous changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting Metricbeat 6.6.0, if a user uses the
elasticsearchmodule for stack monitoring (by settingxpack.enabled: truein theirmodules.d/elasticsearch.yml), they will see no nodes in their Elasticsearch Node Listing page. 😮This is because the UI code relies on the
type=nodes_statsdocuments in.monitoring-es-*to contain asource_nodeproperty with certain fields in it. Theelasticsearch/node_statsmetricset wasn't indexing this property.This PR fixes this bug.