-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the Metadata Refresh stragegy for the Kafka output. #10682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
force-pushed
the
fix/expose-kafka-fullmetadata
branch
from
February 11, 2019 20:31
16dfb9d
to
481323c
Compare
Backport to 6.7, 7.0 |
This need testing with a real cluster to expose the permissions errors. |
ph
force-pushed
the
fix/expose-kafka-fullmetadata
branch
from
February 12, 2019 19:53
481323c
to
c10ddf6
Compare
By default the Kafka output will periodically refresh the metadata information for all the available topics. This is the default strategy that beat uses. But if you have strict permissions in place for your Kafka cluster this could lead to errors in your log while trying to get information for a topic that you don't have permissions. This commit keep the default behavior but allow to change the strategy from the config file.
ph
force-pushed
the
fix/expose-kafka-fullmetadata
branch
from
February 18, 2019 15:38
c10ddf6
to
80fdfa3
Compare
urso
approved these changes
Feb 18, 2019
kvch
approved these changes
Feb 20, 2019
This will go in 7.0 not in 6.7 |
ph
added
v7.0.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Mar 8, 2019
ph
added a commit
to ph/beats
that referenced
this pull request
Mar 13, 2019
…0682) * Expose the Metadata Refresh stragegy for the Kafka output. By default the Kafka output will periodically refresh the metadata information for all the available topics. This is the default strategy that beat uses. But if you have strict permissions in place for your Kafka cluster this could lead to errors in your log while trying to get information for a topic that you don't have permissions. This commit keep the default behavior but allow to change the strategy from the config file. (cherry picked from commit 6829f19)
ph
added a commit
that referenced
this pull request
Mar 13, 2019
…he Kafka output. (#11161) Cherry-pick of PR #10682 to 7.0 branch. Original message: By default the Kafka output will periodically refresh the metadata information for all the available topics. This is the default strategy that beat uses. But if you have strict permissions in place for your Kafka cluster this could lead to errors in your log while trying to get information for a topic that you don't have permissions. This commit keep the default behavior but allow to change the strategy from the config file.
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
…0682) * Expose the Metadata Refresh stragegy for the Kafka output. By default the Kafka output will periodically refresh the metadata information for all the available topics. This is the default strategy that beat uses. But if you have strict permissions in place for your Kafka cluster this could lead to errors in your log while trying to get information for a topic that you don't have permissions. This commit keep the default behavior but allow to change the strategy from the config file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the Kafka output will periodically refresh the metadata
information for all the available topics. This is the default strategy
that beat uses.
But if you have strict permissions in place for your
Kafka cluster this could lead to errors in your log while trying to get
information for a topic that you don't have permissions.
This commit keep the default behavior but allow to change the strategy
from the config file.