Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the Metadata Refresh stragegy for the Kafka output. #10682

Merged
merged 5 commits into from
Feb 27, 2019

Conversation

ph
Copy link
Contributor

@ph ph commented Feb 11, 2019

By default the Kafka output will periodically refresh the metadata
information for all the available topics. This is the default strategy
that beat uses.

But if you have strict permissions in place for your
Kafka cluster this could lead to errors in your log while trying to get
information for a topic that you don't have permissions.

This commit keep the default behavior but allow to change the strategy
from the config file.

@ph ph requested review from a team as code owners February 11, 2019 20:29
@ph ph force-pushed the fix/expose-kafka-fullmetadata branch from 16dfb9d to 481323c Compare February 11, 2019 20:31
@ph ph added the needs_backport PR is waiting to be backported to other branches. label Feb 11, 2019
@ph
Copy link
Contributor Author

ph commented Feb 11, 2019

Backport to 6.7, 7.0

@ph
Copy link
Contributor Author

ph commented Feb 11, 2019

This need testing with a real cluster to expose the permissions errors.

@cwurm cwurm removed the request for review from a team February 12, 2019 11:46
@ph ph removed the request for review from a team February 12, 2019 13:53
@ph ph force-pushed the fix/expose-kafka-fullmetadata branch from 481323c to c10ddf6 Compare February 12, 2019 19:53
By default the Kafka output will periodically refresh the metadata
information for all the available topics. This is the default strategy
that beat uses.

But if you have strict permissions in place for your
Kafka cluster this could lead to errors in your log while trying to get
information for a topic that you don't have permissions.

This commit keep the default behavior but allow to change the strategy
from the config file.
@ph ph force-pushed the fix/expose-kafka-fullmetadata branch from c10ddf6 to 80fdfa3 Compare February 18, 2019 15:38
@ph ph merged commit 6829f19 into elastic:master Feb 27, 2019
@ph
Copy link
Contributor Author

ph commented Mar 5, 2019

This will go in 7.0 not in 6.7

@ph ph added v7.0.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 8, 2019
ph added a commit to ph/beats that referenced this pull request Mar 13, 2019
…0682)

* Expose the Metadata Refresh stragegy for the Kafka output.

By default the Kafka output will periodically refresh the metadata
information for all the available topics. This is the default strategy
that beat uses.

But if you have strict permissions in place for your
Kafka cluster this could lead to errors in your log while trying to get
information for a topic that you don't have permissions.

This commit keep the default behavior but allow to change the strategy
from the config file.

(cherry picked from commit 6829f19)
ph added a commit that referenced this pull request Mar 13, 2019
…he Kafka output. (#11161)

Cherry-pick of PR #10682 to 7.0 branch. Original message: 

By default the Kafka output will periodically refresh the metadata
information for all the available topics. This is the default strategy
that beat uses. 

But if you have strict permissions in place for your
Kafka cluster this could lead to errors in your log while trying to get
information for a topic that you don't have permissions.

This commit keep the default behavior but allow to change the strategy
from the config file.
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
…0682)

* Expose the Metadata Refresh stragegy for the Kafka output.

By default the Kafka output will periodically refresh the metadata
information for all the available topics. This is the default strategy
that beat uses.

But if you have strict permissions in place for your
Kafka cluster this could lead to errors in your log while trying to get
information for a topic that you don't have permissions.

This commit keep the default behavior but allow to change the strategy
from the config file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants