[Filebeat] [Netflow] fix field name conversion to snake case #10950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansr
added
bug
review
Filebeat
|
Pinging @elastic/secops |
4 tasks
adriansr
changed the title
webmat
reviewed
Feb 27, 2019
| "post_nadt_estination_ipv4_address": "192.168.128.17", | ||
| "post_nast_ource_ipv4_address": "192.168.230.216", | ||
| "post_nat_destination_ipv4_address": "192.168.128.17", | ||
| "post_nat_source_ipv4_address": "192.168.230.216", |
| "post_napst_ource_transport_port": 61776, | ||
| "post_nast_ource_ipv4_address": "192.168.0.2", | ||
| "post_napt_destination_transport_port": 80, | ||
| "post_napt_source_transport_port": 61776, |
There was a problem hiding this comment.
Turns out is a legit name, see IPFIX field 227 postNAPTSourceTransportPort.
Stands for "Network Address Port Translation". Got me scared in there because there's a NATP acronym too 😅
|
|
||
| func TestCamelCaseToSnakeCase(t *testing.T) { | ||
| for _, testCase := range [][2]string{ | ||
| {"aBCDe", "a_bc_de"}, |
Original field name conversion was buggy.
adriansr
force-pushed
the
fix_netflow_field_naming
branch
from
d90cd8b
to
42957dc
Compare
webmat
approved these changes
Feb 27, 2019
|
Hope you don't mind I renamed a variable in this fix PR. I couldn't stand the ridiculous name (I meant STRIDE, which isn't a correct name for what the variable holds) |
|
Why didn't you go with |
|
jenkins, test this |
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Mar 1, 2019
Bug fix was missing an entry in CHANGELOG.next
adriansr
added
v6.6.2
and removed
needs_backport
adriansr
added a commit
that referenced
this pull request
Mar 1, 2019
adriansr
added a commit
that referenced
this pull request
Mar 1, 2019
adriansr
added a commit
that referenced
this pull request
Mar 1, 2019
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Mar 1, 2019
Bug fix was missing an entry in CHANGELOG.next (cherry picked from commit e0bbf2e)
adriansr
added a commit
that referenced
this pull request
Mar 2, 2019
adriansr
added a commit
that referenced
this pull request
Mar 5, 2019
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Mar 5, 2019
Bug fix was missing an entry in CHANGELOG.next (cherry picked from commit b6c05a2)
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Mar 5, 2019
Bug fix was missing an entry in CHANGELOG.next (cherry picked from commit b6c05a2)
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Mar 5, 2019
Bug fix was missing an entry in CHANGELOG.next (cherry picked from commit b6c05a2)
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Mar 5, 2019
Bug fix was missing an entry in CHANGELOG.next (cherry picked from commit b6c05a2)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…#10950) (elastic#11019) Original field name conversion was buggy. (cherry picked from commit 02e1cc5)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Bug fix was missing an entry in CHANGELOG.next (cherry picked from commit 7aaa37d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial release field name conversion was buggy:
postNATSourceIPv4Address=>post_nast_ource_ipv4_addressThis includes special treatment for badly named field
VRFname, by convention it should beVRFName.