[metricbeat] implement Close() for docker metricsets #11294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
bug
Metricbeat
ruflin
approved these changes
Mar 19, 2019
fearful-symmetry
force-pushed
the
docker-container-metricset-close
branch
from
ea4374a
to
4129418
Compare
|
I think we should implement Let's do all of them in this PR so we keep them together also for backporting as they are going to be the same thing. |
fearful-symmetry
changed the title
jsoriano
approved these changes
Mar 19, 2019
Co-Authored-By: fearful-symmetry <8418476+fearful-symmetry@users.noreply.github.com>
|
@fearful-symmetry We should also backport this to 7.0 as it's a bug. |
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Mar 20, 2019
* implement Close() for docker metricsets (cherry picked from commit 57f8b5c)
fearful-symmetry
added a commit
that referenced
this pull request
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info at #11266
This is something I noticed while looking over the inconsistencies in how various metricsets do or do not implement a
Close().@ruflin Mentioned that there may be some weird behavior around docker and closing connections. As of now this looks straightforward, but we can check to see if something crops up during CI.