Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ECS options in filebeat pipelines when not available #11362

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Remove ECS options in filebeat pipelines when not available #11362

merged 2 commits into from
Mar 21, 2019

Conversation

jsoriano
Copy link
Member

Similar to #10875, but removing ecs flags when using pipelines on
Elasticsearch versions below 6.7.0, that don't have them.

@jsoriano
Remove ECS options in filebeat pipelines when not available
682a605 
Similar to elastic#10875, but removing ecs flags when using pipelines on
Elasticsearch versions below 6.7.0, that don't have them.
@jsoriano jsoriano added bug review Filebeat Filebeat Team:Integrations Label for the Integrations team v6.7.0 labels Mar 21, 2019
@jsoriano jsoriano self-assigned this Mar 21, 2019
@jsoriano jsoriano requested review from tsg and ruflin March 21, 2019 09:05
@tsg
Copy link
Contributor

tsg commented Mar 21, 2019

FYI, system/syslog uses a different approach for this: https://github.com/elastic/beats/blob/master/filebeat/module/system/syslog/manifest.yml#L11-L17

But this is also fine.

tsg
tsg approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jsoriano jsoriano merged commit 79800ae into elastic:6.7 Mar 21, 2019
@jsoriano jsoriano deleted the filebeat-remove-ecs-option branch March 21, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsg tsg tsg approved these changes

@ruflin ruflin ruflin approved these changes

Assignees

@jsoriano jsoriano

Labels
bug Filebeat Filebeat review Team:Integrations Label for the Integrations team v6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoriano @tsg @ruflin