Add _bucket to histogram metrics in Prometheus Collector #11578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
vjsamuel
changed the title
|
ok to test |
exekias
approved these changes
Apr 2, 2019
exekias
added
bug
needs_backport
|
This seems to be a breaking change? |
|
yes, this is a missing change from #9948, I would like to push it to 7.0, where the breaking change happens already |
exekias
reviewed
Apr 2, 2019
CHANGELOG.asciidoc
Outdated
| @@ -114,6 +114,7 @@ https://github.com/elastic/beats/compare/v7.0.0-beta1...v7.0.0-rc1[Check the HEA | |||
| - Add missing aws.ec2.instance.state.name into fields.yml. {issue}11219[11219] {pull}11221[11221] | |||
| - Fix ec2 metricset to collect metrics from Cloudwatch with the same timestamp. {pull}11142[11142] | |||
| - Fix potential memory leak in stopped docker metricsets {pull}11294[11294] | |||
| - Add _bucket to histogram metrics in Prometheus Collector {pull}11578[11578] | |||
There was a problem hiding this comment.
can you please move this to CHANGELOG.next.asciidoc?
|
WFG |
|
thank you @vjsamuel for fixing this! 🎉 |
exekias
removed
the
needs_backport
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
Apr 2, 2019
* Add _bucket to histogram metrics (cherry picked from commit 9835571)
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
Apr 2, 2019
* Add _bucket to histogram metrics (cherry picked from commit 9835571)
exekias
added a commit
that referenced
this pull request
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names of histograms vary because of the lack of
_bucketon the name. Can we please add this to make sure that the names are consistent?