Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libbeat] Fix documentation of output.kafka.key #14333

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Conversation

faec
Copy link
Contributor

@faec faec commented Oct 30, 2019

A recent discuss post pointed out an inaccuracy in the docs for output.kafka.key. I've clarified the description of the field.

@faec faec added docs libbeat needs_backport PR is waiting to be backported to other branches. labels Oct 30, 2019
@faec faec requested a review from dedemorton October 30, 2019 16:27
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@faec faec merged commit ee37bc1 into elastic:master Nov 5, 2019
@faec faec deleted the doc-fix branch November 5, 2019 21:28
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Feb 21, 2020
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Feb 21, 2020
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Feb 21, 2020
dedemorton added a commit that referenced this pull request Feb 21, 2020
Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
dedemorton added a commit that referenced this pull request Feb 24, 2020
Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
jorgemarey pushed a commit to jorgemarey/beats that referenced this pull request Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants