Added path.logs and made logging to files the default #1437
Conversation
This adds the `-path.logs` CLI flag and corresponding config file
setting. By default it's set to `{path.home}/logs`. The rotating
file writer now writes to this path by default.
For DEB/RPM, the logs path is set to `/var/log/{beatname}` which
matches the previous default location. However, this is a breaking
change because the previous default was to send the logs to syslog.
Part of elastic#1371.
| default: | ||
| logp.WTF("Unknown file type: %s", fileType) | ||
| return "" | ||
| panic(fmt.Sprintf("Unknown file type: %s", fileType)) |
There was a problem hiding this comment.
I would prefer to return an error here instead of using panic.
There was a problem hiding this comment.
That would mean the function would have to return an error, which would complicate usage for little benefit. Note that because FileType is a custom type, the caller won't be able to pass an invalid value here (compile time error).
The only case where the panic would hit is if someone adds a new entry to the "enum"in this file but forgets to add it here. A panic is fine in that case, IMHO, because it's clearly a development bug that should be discovered before committing.
|
LGTM. See comment above. The migration for the log part from 1.x to 5.x will be quite easy. People only have to make a change in their config file. Should we create a docs with Migration from 1.2.x to 5.0.x where we add this kind of stuff? |
This adds the
-path.logsCLI flag and corresponding config filesetting. By default it's set to
{path.home}/logs. The rotatingfile writer now writes to this path by default.
For DEB/RPM, the logs path is set to
/var/log/{beatname}whichmatches the previous default location. However, this is a breaking
change because the previous default was to send the logs to syslog.
Part of #1371.