Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make additional credentials available for tests #14990

Merged
merged 4 commits into from
Dec 16, 2019

Conversation

graphaelli
Copy link
Member

To support elastic/apm-server#2799. These are not currently used directly in elastic/beats

@graphaelli graphaelli added Team:apm APM Server team issues/PRs Team:Beats labels Dec 6, 2019
@graphaelli graphaelli requested a review from a team December 11, 2019 18:58
@graphaelli
Copy link
Member Author

Thanks for the review @kvch. These test failures surprising based on these changes, how should I proceed?

@kvch
Copy link
Contributor

kvch commented Dec 16, 2019

Why do you think that? I cannot see any failure related to this change. Jenkins and Travis are both green.

@graphaelli
Copy link
Member Author

I see
image. But looking into each of those I don't see how they are related to this change, I'll merge it in now.

@graphaelli graphaelli merged commit 77acacf into elastic:master Dec 16, 2019
@graphaelli graphaelli deleted the apm-xpack-security branch December 16, 2019 14:45
graphaelli added a commit to graphaelli/beats that referenced this pull request Dec 16, 2019
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:apm APM Server team issues/PRs Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants