Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Clarify changes in monitoring settings #15003

Merged
merged 4 commits into from
Jan 8, 2020

Conversation

dedemorton
Copy link
Contributor

Closes #13994

Marking as WIP because I want to verify that the general structure/approach works before proceeding.

I plan to backport this to 7.2 to clarify the messaging.

@ycombinator Can you take a look and see if I'm on the right track. Note that I took the "legacy" settings from 7.1. Let me know if that's not the right approach (I'm assuming they were not changed between 7.1 and 7.2).

@dedemorton dedemorton added docs in progress Pull request is currently in progress. needs_backport PR is waiting to be backported to other branches. v7.2.0 v7.3.0 v7.4.0 v7.5.0 v7.6.0 labels Dec 7, 2019
@ycombinator
Copy link
Contributor

@dedemorton
Copy link
Contributor Author

@ycombinator Yup, that preview link will work!

@ycombinator
Copy link
Contributor

I'm a little torn about the ordering of the collection methods presented in this PR. I wonder if it should be Internal collection*, Metricbeat collection, then Legacy collection* (deprecated) instead.

I say this because, in 7.x we're going to want users to use the Internal collection method for sure to ease their upgrade pain. In 8.0/8.x we'd want to do the same until Agent becomes available. In short, while Metricbeat collection is an option for users, I don't think we want to emphasize it too much for monitoring other Beats. @cachedout @jakelandis @ph do you have any opinions here as well, based on our recent discussions?

*See my other comment in the PR about the naming of "Internal collection" and "Legacy collection".

@dedemorton
Copy link
Contributor Author

I think this terminology might be confusing, since we use "Internal collection" for other products to mean "internal collection sending data to the production cluster" (what you're calling "legacy collection" below).

Agreed...do you think it would be better if I called them: "internal collection" and "internal collection (legacy)" (so it's clear that they're both basically internal collection, but the one flagged "legacy" is old and deprecated)?

@dedemorton
Copy link
Contributor Author

dedemorton commented Dec 9, 2019

I tried a version where I spelled things out in the title (Internal collection - sending to the production cluster and Internal collection - sending directly to the monitoring cluster), but I was concerned that users who don't have a dedicated monitoring cluster might think the first topic applied to them. Also long titles can be problematic.

@ycombinator
Copy link
Contributor

Perhaps the solution here is to call them "internal collection" and "internal collection (legacy)" but to also update other products' docs to use the "internal collection (legacy)" title?

@dedemorton
Copy link
Contributor Author

@karenzone WDYT about the naming that I've proposed here? I'm open to better ideas!

@karenzone
Copy link
Contributor

All good points in the previous discussions.

What about "internal collection," and "legacy internal collection (deprecated)." If you use internal collection (legacy), that sets you up for back-to-back parentheticals when you add (deprecated).

Screen Shot 2019-12-09 at 2 31 31 PM

@dedemorton dedemorton removed the in progress Pull request is currently in progress. label Dec 9, 2019
@dedemorton dedemorton changed the title [WIP][DOCS] Clarify changes in monitoring settings [DOCS] Clarify changes in monitoring settings Dec 9, 2019
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator
Copy link
Contributor

@dedemorton Post-holiday bump :)

@dedemorton
Copy link
Contributor Author

Post-holiday bump :)

Hey who took away the eggnog?

@ycombinator
Copy link
Contributor

@dedemorton Looks like this needs a rebase with master to update the NOTICE.txt file with the new year.

@dedemorton
Copy link
Contributor Author

@ycombinator I've rebased. Is this ready to merge?

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nit comment. Otherwise LGTM. Thanks @dedemorton!

@dedemorton dedemorton merged commit 92b5dbd into elastic:master Jan 8, 2020
@dedemorton dedemorton deleted the issue#13994 branch January 8, 2020 23:11
dedemorton added a commit to dedemorton/beats that referenced this pull request Jan 9, 2020
* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc
dedemorton added a commit to dedemorton/beats that referenced this pull request Jan 9, 2020
* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc
dedemorton added a commit to dedemorton/beats that referenced this pull request Jan 9, 2020
* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc
dedemorton added a commit to dedemorton/beats that referenced this pull request Jan 9, 2020
* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc
dedemorton added a commit to dedemorton/beats that referenced this pull request Jan 9, 2020
* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc
dedemorton added a commit to dedemorton/beats that referenced this pull request Jan 9, 2020
* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc
dedemorton added a commit that referenced this pull request Jan 10, 2020
* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc
dedemorton added a commit that referenced this pull request Jan 10, 2020
* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc
dedemorton added a commit that referenced this pull request Jan 10, 2020
…#15438)

* [DOCS] Clarify changes in monitoring settings (#15003)

* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc

* Update notice file
dedemorton added a commit that referenced this pull request Jan 10, 2020
…#15440)

* [DOCS] Clarify changes in monitoring settings (#15003)

* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc

* Update the notice file
dedemorton added a commit to dedemorton/beats that referenced this pull request Jan 14, 2020
* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Jan 14, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…c#15436)

* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…#15003) (elastic#15438)

* [DOCS] Clarify changes in monitoring settings (elastic#15003)

* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc

* Update notice file
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…#15003) (elastic#15440)

* [DOCS] Clarify changes in monitoring settings (elastic#15003)

* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc

* Update the notice file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document change to monitoring settings in 7.2 and later
4 participants