-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Clarify changes in monitoring settings #15003
Conversation
Will do on Monday, @dedemorton! Is this the right preview URL? http://beats_15003.docs-preview.app.elstc.co/guide/en/beats/auditbeat/master/monitoring.html |
@ycombinator Yup, that preview link will work! |
I'm a little torn about the ordering of the collection methods presented in this PR. I wonder if it should be Internal collection*, Metricbeat collection, then Legacy collection* (deprecated) instead. I say this because, in 7.x we're going to want users to use the Internal collection method for sure to ease their upgrade pain. In 8.0/8.x we'd want to do the same until Agent becomes available. In short, while Metricbeat collection is an option for users, I don't think we want to emphasize it too much for monitoring other Beats. @cachedout @jakelandis @ph do you have any opinions here as well, based on our recent discussions? *See my other comment in the PR about the naming of "Internal collection" and "Legacy collection". |
Agreed...do you think it would be better if I called them: "internal collection" and "internal collection (legacy)" (so it's clear that they're both basically internal collection, but the one flagged "legacy" is old and deprecated)? |
I tried a version where I spelled things out in the title (Internal collection - sending to the production cluster and Internal collection - sending directly to the monitoring cluster), but I was concerned that users who don't have a dedicated monitoring cluster might think the first topic applied to them. Also long titles can be problematic. |
Perhaps the solution here is to call them "internal collection" and "internal collection (legacy)" but to also update other products' docs to use the "internal collection (legacy)" title? |
@karenzone WDYT about the naming that I've proposed here? I'm open to better ideas! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dedemorton Post-holiday bump :) |
Hey who took away the eggnog? |
@dedemorton Looks like this needs a rebase with |
eaf9f2c
to
b7ccf86
Compare
@ycombinator I've rebased. Is this ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a nit comment. Otherwise LGTM. Thanks @dedemorton!
* [DOCS] Clarify changes in monitoring settings * Change topic names and order * Add more fixes from the review * Update libbeat/docs/monitoring/monitoring-beats.asciidoc
* [DOCS] Clarify changes in monitoring settings * Change topic names and order * Add more fixes from the review * Update libbeat/docs/monitoring/monitoring-beats.asciidoc
* [DOCS] Clarify changes in monitoring settings * Change topic names and order * Add more fixes from the review * Update libbeat/docs/monitoring/monitoring-beats.asciidoc
* [DOCS] Clarify changes in monitoring settings * Change topic names and order * Add more fixes from the review * Update libbeat/docs/monitoring/monitoring-beats.asciidoc
* [DOCS] Clarify changes in monitoring settings * Change topic names and order * Add more fixes from the review * Update libbeat/docs/monitoring/monitoring-beats.asciidoc
* [DOCS] Clarify changes in monitoring settings * Change topic names and order * Add more fixes from the review * Update libbeat/docs/monitoring/monitoring-beats.asciidoc
* [DOCS] Clarify changes in monitoring settings * Change topic names and order * Add more fixes from the review * Update libbeat/docs/monitoring/monitoring-beats.asciidoc
…c#15436) * [DOCS] Clarify changes in monitoring settings * Change topic names and order * Add more fixes from the review * Update libbeat/docs/monitoring/monitoring-beats.asciidoc
…#15003) (elastic#15438) * [DOCS] Clarify changes in monitoring settings (elastic#15003) * [DOCS] Clarify changes in monitoring settings * Change topic names and order * Add more fixes from the review * Update libbeat/docs/monitoring/monitoring-beats.asciidoc * Update notice file
…#15003) (elastic#15440) * [DOCS] Clarify changes in monitoring settings (elastic#15003) * [DOCS] Clarify changes in monitoring settings * Change topic names and order * Add more fixes from the review * Update libbeat/docs/monitoring/monitoring-beats.asciidoc * Update the notice file
Closes #13994
Marking as WIP because I want to verify that the general structure/approach works before proceeding.
I plan to backport this to 7.2 to clarify the messaging.
@ycombinator Can you take a look and see if I'm on the right track. Note that I took the "legacy" settings from 7.1. Let me know if that's not the right approach (I'm assuming they were not changed between 7.1 and 7.2).