Journalbeat: add index option to input #15071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 12, 2019
7 tasks
houndci-bot
reviewed
Dec 12, 2019
houndci-bot
reviewed
Dec 12, 2019
| procs.List = append(procs.List, p) | ||
| } | ||
|
|
||
| func (procs *Processors) AddProcessors(p Processors) { |
There was a problem hiding this comment.
exported method Processors.AddProcessors should have comment or be unexported
| @@ -103,10 +103,25 @@ func New(config PluginConfig) (*Processors, error) { | |||
| return procs, nil | |||
| } | |||
|
|
|||
| func (procs *Processors) add(p Processor) { | |||
| func (procs *Processors) AddProcessor(p Processor) { | |||
There was a problem hiding this comment.
exported method Processors.AddProcessor should have comment or be unexported
ycombinator
added
enhancement
Journalbeat
libbeat
needs_backport
|
Travis CI is green. Jenkins CI failures are unrelated. Merging. |
ycombinator
added a commit
to ycombinator/beats
that referenced
this pull request
Dec 16, 2019
* Refactoring: renaming var to avoid collision * Refactoring: extract function * Refactoring: moving AddFormattedIndex processor into libbeat * Add constructor for addFormattedIndex processor * Export processor struct * Add comment for exported constructor * Adding comment for exported method * Adding index option to doc * Refactoring: extracting common code * Adding unit tests * Adding godoc for exported methods
ycombinator
added a commit
that referenced
this pull request
Dec 17, 2019
* Refactoring: renaming var to avoid collision * Refactoring: extract function * Refactoring: moving AddFormattedIndex processor into libbeat * Add constructor for addFormattedIndex processor * Export processor struct * Add comment for exported constructor * Adding comment for exported method * Adding index option to doc * Refactoring: extracting common code * Adding unit tests * Adding godoc for exported methods
ycombinator
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15063.
Building on top of the work @faec did in #14010, this PR allows Journalbeat inputs to take a new option,
index. The value of this option determines which Elasticsearch index should be used by the Elasticsearch output for indexing Journalbeat events produced by that input. For other outputs, the index name is passed via the@metadata["raw_index"]field.For example, with this
journalbeat.ymlconfiguration:Running
journalbeat -ewill result in events like: