Add cost warning messages to azure get metric values calls #15356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narph
added
Metricbeat
kaiyan-sheng
reviewed
Jan 7, 2020
| @@ -100,6 +103,11 @@ func (service *MonitorService) GetMetricValues(resourceID string, namespace stri | |||
| } | |||
| resp, err := service.metricsClient.List(service.context, resourceID, timespan, tg, strings.Join(metricNames[i:end], ","), | |||
| aggregations, nil, "", filter, insights.Data, namespace) | |||
|
|
|||
| // check for applied charges before returning any errors | |||
| if resp.Cost != nil && *resp.Cost != 0 { | |||
There was a problem hiding this comment.
This is awesome! I wish AWS has it as well...
kaiyan-sheng
approved these changes
Jan 7, 2020
narph
added
needs_backport
zube
bot
added
[zube]: Done
needs_backport
narph
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cost warning messages to azure get metric values calls.
The azure response object contains the cost value for each api call, if not 0 we will log a warning message.