Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.2][DOCS] Backport: Clarify changes in monitoring settings (#15003) #15443

Closed
wants to merge 2 commits into from
Closed

[7.2][DOCS] Backport: Clarify changes in monitoring settings (#15003) #15443

wants to merge 2 commits into from

Conversation

dedemorton
Copy link
Contributor

Backports #15003 to 7.2 branch

@dedemorton
[DOCS] Clarify changes in monitoring settings (elastic#15003)
6b03229 
* [DOCS] Clarify changes in monitoring settings

* Change topic names and order

* Add more fixes from the review

* Update libbeat/docs/monitoring/monitoring-beats.asciidoc
@dedemorton dedemorton requested a review from a team as a code owner January 9, 2020 21:57
@dedemorton dedemorton changed the title [DOCS] Clarify changes in monitoring settings (#15003) [7.2][DOCS] Backport: Clarify changes in monitoring settings (#15003) Jan 9, 2020
@ycombinator
Copy link
Contributor

ycombinator commented Jan 10, 2020 •
edited
Loading

Some of the content in this backport PR seems to be coming from #13090. Would it make sense to backport #13090 to 7.2 first? That might make this backport PR here cleaner.

@dedemorton
Copy link
Contributor Author

Would it make sense to backport #13090 to 7.2 first? That might make this backport PR here cleaner.

Yah, that's a good point. I'll create a new PR and close this one.

@dedemorton dedemorton closed this Jan 10, 2020
@dedemorton dedemorton deleted the backport_15003_7.2 branch January 14, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator Awaiting requested review from ycombinator

Assignees
No one assigned
Labels
backport docs review v7.2.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dedemorton @ycombinator