Do not load dashboards where not available #15802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakerouse
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
Looks good to me.
This is a good improvement because from the command output I would expect that functionbeat was supposed to have a dashboard but it was just missing in the released files. From this change I can tell that actually it doesn't have a dashboard at all so those messages should not be shown in the case of functionbeat (also in the case for some others).
houndci-bot
reviewed
Jan 24, 2020
| @@ -31,7 +31,7 @@ import ( | |||
| var Version = "9.9.9" | |||
| var Name = "mockbeat" | |||
|
|
|||
| var Settings = instance.Settings{Name: Name, Version: Version} | |||
| var Settings = instance.Settings{Name: Name, Version: Version, HasDashboards: true} | |||
There was a problem hiding this comment.
exported var Settings should have comment or be unexported
houndci-bot
reviewed
Jan 24, 2020
| @@ -31,7 +31,7 @@ import ( | |||
| var Version = "9.9.9" | |||
| var Name = "mockbeat" | |||
|
|
|||
| var Settings = instance.Settings{Name: Name, Version: Version} | |||
| var Settings = instance.Settings{Name: Name, Version: Version, HasDashboards: true} | |||
There was a problem hiding this comment.
exported var Settings should have comment or be unexported
kvch
force-pushed
the
fix-libbeat-do-not-load-dashboards
branch
from
07a2998
to
5f5ea30
Compare
5 tasks
kvch
added a commit
to kvch/beats
that referenced
this pull request
Jan 27, 2020
## What does this PR do? This PR adds a new setting to Beat to indicate if it has a dashboard or not. If the Beat lacks dashboards, running `setup` does not attempt to load those. ## Why is it important? Running the command `setup` fails if the Beat does not have dashboards in the appropriate folder. ## Checklist <!-- Mandatory Add a checklist of things that are required to be reviewed in order to have the PR approved List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~) --> - [x] My code follows the style guidelines of this project - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] I have made the corresponding change to the default configuration files - [x] I have added tests that prove my fix is effective or that my feature works ## How to test this PR locally Both Journalbeat and Functionbeat are affected. So both Beats can/should be tested. ```sh ./functionbeat setup ``` ## Related issues Closes elastic#13276 Closes elastic#11751 (cherry picked from commit 8260623)
kvch
added
v7.7.0
and removed
needs_backport
5 tasks
kvch
added a commit
that referenced
this pull request
Jan 27, 2020
## What does this PR do? This PR adds a new setting to Beat to indicate if it has a dashboard or not. If the Beat lacks dashboards, running `setup` does not attempt to load those. ## Why is it important? Running the command `setup` fails if the Beat does not have dashboards in the appropriate folder. ## Checklist <!-- Mandatory Add a checklist of things that are required to be reviewed in order to have the PR approved List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~) --> - [x] My code follows the style guidelines of this project - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] I have made the corresponding change to the default configuration files - [x] I have added tests that prove my fix is effective or that my feature works ## How to test this PR locally Both Journalbeat and Functionbeat are affected. So both Beats can/should be tested. ```sh ./functionbeat setup ``` ## Related issues Closes #13276 Closes #11751 (cherry picked from commit 8260623)
kvch
added a commit
to kvch/beats
that referenced
this pull request
Jan 28, 2020
## What does this PR do? This PR adds a new setting to Beat to indicate if it has a dashboard or not. If the Beat lacks dashboards, running `setup` does not attempt to load those. ## Why is it important? Running the command `setup` fails if the Beat does not have dashboards in the appropriate folder. ## Checklist <!-- Mandatory Add a checklist of things that are required to be reviewed in order to have the PR approved List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~) --> - [x] My code follows the style guidelines of this project - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] I have made the corresponding change to the default configuration files - [x] I have added tests that prove my fix is effective or that my feature works ## How to test this PR locally Both Journalbeat and Functionbeat are affected. So both Beats can/should be tested. ```sh ./functionbeat setup ``` ## Related issues Closes elastic#13276 Closes elastic#11751 (cherry picked from commit 8260623)
kvch
added a commit
that referenced
this pull request
Jan 28, 2020
…#15851) * Do not load dashboards where not available (#15802) ## What does this PR do? This PR adds a new setting to Beat to indicate if it has a dashboard or not. If the Beat lacks dashboards, running `setup` does not attempt to load those. ## Why is it important? Running the command `setup` fails if the Beat does not have dashboards in the appropriate folder. ## Checklist <!-- Mandatory Add a checklist of things that are required to be reviewed in order to have the PR approved List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~) --> - [x] My code follows the style guidelines of this project - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] I have made the corresponding change to the default configuration files - [x] I have added tests that prove my fix is effective or that my feature works ## How to test this PR locally Both Journalbeat and Functionbeat are affected. So both Beats can/should be tested. ```sh ./functionbeat setup ``` ## Related issues Closes #13276 Closes #11751 (cherry picked from commit 8260623) * fix changelog again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new setting to Beat to indicate if it has a dashboard or not. If the Beat lacks dashboards, running
setupdoes not attempt to load those.Why is it important?
Running the command
setupfails if the Beat does not have dashboards in the appropriate folder.Checklist
How to test this PR locally
Both Journalbeat and Functionbeat are affected. So both Beats can/should be tested.
Related issues
Closes #13276
Closes #11751