[Metricbeat] Update tablespace metricset in the Oracle module docs to include required permissions #16436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a lack of details in this document regarding required permissions to the underlying database in order for the module to collect this information. This may still need additional review. This is similar to change made here elastic#14496 but for the `tablespace` metricset.
dedemorton
added
docs
needs_backport
dedemorton
changed the title
|
Would you mind doing a quick review. It's for bookkeeping purposes since you've already approved the changes in #14497. |
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Feb 21, 2020
… include required permissions (elastic#16436) * Update doc to include required permissions There is a lack of details in this document regarding required permissions to the underlying database in order for the module to collect this information. This may still need additional review. This is similar to change made here elastic#14496 but for the `tablespace` metricset. * Add float tag Co-authored-by: Robbert Hink <robbert.hink@elastic.co>
dedemorton
added a commit
that referenced
this pull request
Feb 24, 2020
… include required permissions (#16436) (#16501) * Update doc to include required permissions There is a lack of details in this document regarding required permissions to the underlying database in order for the module to collect this information. This may still need additional review. This is similar to change made here #14496 but for the `tablespace` metricset. * Add float tag Co-authored-by: Robbert Hink <robbert.hink@elastic.co> Co-authored-by: Robbert Hink <robbert.hink@elastic.co>
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Feb 29, 2020
… include required permissions (elastic#16436) * Update doc to include required permissions There is a lack of details in this document regarding required permissions to the underlying database in order for the module to collect this information. This may still need additional review. This is similar to change made here elastic#14496 but for the `tablespace` metricset. * Add float tag Co-authored-by: Robbert Hink <robbert.hink@elastic.co>
dedemorton
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #14497
(cherry-picking the commit was easier than getting the PR to pass tests because the dev environment has changed)