Remove stateful processors from the script processor #16514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some processors that keep resources that would need to be explicitly released when the processor is not needed anymore. At this moment there is no way to do it, processors have a stateless interface so avoid using these processors in scripts. If these processors are needed, it is usually better to place them in global configuration. Processors removed are the ones used to add docker and kubernetes metadata.
jsoriano
added
Team:Integrations
jsoriano
added
[zube]: In Review
review
needs_backport
zube
bot
removed
needs_backport
jsoriano
added
needs_backport
…-processors-script
kaiyan-sheng
approved these changes
Feb 24, 2020
andrewkroh
approved these changes
Feb 24, 2020
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Feb 25, 2020
There are some processors that keep resources that would need to be explicitly released when the processor is not needed anymore. At this moment there is no way to do it, processors have a stateless interface, so avoid using these processors in scripts. If these processors are needed, it is usually better to place them in global configuration. Processors removed are the ones used to add docker and kubernetes metadata. (cherry picked from commit 8d31a51)
jsoriano
removed
the
needs_backport
jsoriano
added a commit
that referenced
this pull request
Mar 12, 2020
There are some processors that keep resources that would need to be explicitly released when the processor is not needed anymore. At this moment there is no way to do it, processors have a stateless interface, so avoid using these processors in scripts. If these processors are needed, it is usually better to place them in global configuration. Processors removed are the ones used to add docker and kubernetes metadata. (cherry picked from commit 8d31a51)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove stateful processors from the script processor.
This is a breaking change because it will make scripts fail if they use these
processors. But it is quite unlikely that these processors are used in scripts
in production deployments because they would produce memory and file
descriptor leaks.
Why is it important?
There are some processors that keep resources that would need to be
explicitly released when the processor is not needed anymore. At this
moment there is no way to do it, processors have a stateless interface,
so avoid using these processors in scripts.
If these processors are needed, it is usually better to place them in
global configuration.
Processors removed are the ones used to add docker and kubernetes
metadata.
Related issues
More context in #16349.