Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add_cloudfoundry_metadata to use debug log, add missing cache_duraction doc #16998

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Mar 13, 2020

What does this PR do?

Fixes an issue where the add_cloudfoundry_metadata process reported missing applications as a warning log. This spammed the logs of metricbeat and filebeat, because PCF has some applications that cannot be references from the API. This changes it to debug log, so its not own by default and can be turned on if the user wanted.

Includes a drive-by fix for the missing cache_duration documentation on the add_cloudfoundry_metadata.

Why is it important?

To not spam the logs with warning messages, that will always occur in PCF.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • Doesn't spam the logs with warn messages.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@blakerouse blakerouse requested a review from a team March 13, 2020 13:21
@blakerouse blakerouse added docs Team:Platforms Label for the Integrations - Platforms team labels Mar 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@blakerouse blakerouse merged commit 8d267b7 into elastic:master Mar 16, 2020
@blakerouse blakerouse deleted the cf-missing-app-debug branch March 16, 2020 15:05
blakerouse added a commit to blakerouse/beats that referenced this pull request Mar 16, 2020
…to add_cloudfoundry_metadata documentation. (elastic#16998)

(cherry picked from commit 8d267b7)
blakerouse added a commit that referenced this pull request Mar 19, 2020
…to add_cloudfoundry_metadata documentation. (#16998) (#17027)

(cherry picked from commit 8d267b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Team:Platforms Label for the Integrations - Platforms team v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants