Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy missing go version to the generated Beats #17105

Merged
merged 4 commits into from
Mar 19, 2020
Merged

Copy missing go version to the generated Beats #17105

merged 4 commits into from
Mar 19, 2020

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Mar 19, 2020 •
edited by zube bot
Loading

What does this PR do?

This PR makes beat generator copy .go-version to the vendored beats folder as it is not copied automatically.

Why is it important?

If the file .go-version is missing, the beat cannot be generated and package properly.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

$ make -C generator/_templates/beat test test-package

Related issues

@kvch kvch added [zube]: In Progress Team:Services (Deprecated) Label for the former Integrations-Services team labels Mar 19, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@kvch kvch added the needs_backport PR is waiting to be backported to other branches. label Mar 19, 2020
fearful-symmetry
fearful-symmetry requested changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than wrapping the errors, this looks great!

dev-tools/mage/gomod.go Outdated Show resolved Hide resolved
jsoriano
jsoriano approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. If it looks good to travis, it LGTM.

@kvch
Copy link
Contributor Author

kvch commented Mar 19, 2020

Relevant tests are green.

@kvch kvch merged commit 6cf8764 into elastic:master Mar 19, 2020
This was referenced Mar 19, 2020
Closed
Merged
kvch added a commit to kvch/beats that referenced this pull request Mar 19, 2020
@kvch
Copy missing go version to the generated Beats (elastic#17105)
3291641 
This PR makes beat generator copy `.go-version` to the vendored beats folder as it is not copied automatically.

If the file `.go-version` is missing, the beat cannot be generated and package properly.
(cherry picked from commit 6cf8764)
@kvch kvch added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 19, 2020
kvch added a commit that referenced this pull request Mar 19, 2020
@kvch
Copy missing go version to the generated Beats (#17105) (#17118)
843d7da 
This PR makes beat generator copy `.go-version` to the vendored beats folder as it is not copied automatically.

If the file `.go-version` is missing, the beat cannot be generated and package properly.
(cherry picked from commit 6cf8764)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@fearful-symmetry fearful-symmetry fearful-symmetry approved these changes

Assignees
No one assigned
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beat generator test and test-pacakge jobs on Travis are failing
5 participants
@kvch @elasticmachine @jsoriano @fearful-symmetry @andresrc