Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pattern to handle logs from newer ES versions #17406

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Apr 1, 2020

What does this PR do?

Adds another date format pattern to accept dates with or without timezones, as seen in Elasticsearch audit logs. Older versions of Elasticsearch omit the timezone while newer versions introduce it. The change in this PR will allow the ingest pipeline to handle both.

Why is it important?

It fixes a bug introduced in #15942. Due to that bug, users who upgrade to Filebeat 7.6.0 or later are seeing errors like this:

          "error" : {
            "message" : "Text '2020-04-01T11:21:06,725+0200' could not be parsed, unparsed text found at index 23"
          }

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring (Stack monitoring)

@ycombinator ycombinator added Team:Services (Deprecated) Label for the former Integrations-Services team and removed Team:Integrations Label for the Integrations team labels Apr 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@elastic elastic deleted a comment from elasticmachine Apr 1, 2020
@ycombinator ycombinator added [zube]: In Review needs_backport PR is waiting to be backported to other branches. v7.8.0 v8.0.0 labels Apr 1, 2020
@zube zube bot removed needs_backport PR is waiting to be backported to other branches. v7.8.0 v8.0.0 labels Apr 1, 2020
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@ycombinator ycombinator merged commit 9009938 into elastic:master Apr 1, 2020
@ycombinator ycombinator deleted the fb-es-audit-tz-compat branch April 1, 2020 23:52
ycombinator added a commit to ycombinator/beats that referenced this pull request Apr 1, 2020
* Add pattern to handle logs from newer ES versions

* Adding CHANGELOG entry
ycombinator added a commit to ycombinator/beats that referenced this pull request Apr 1, 2020
* Add pattern to handle logs from newer ES versions

* Adding CHANGELOG entry
ycombinator added a commit to ycombinator/beats that referenced this pull request Apr 2, 2020
* Add pattern to handle logs from newer ES versions

* Adding CHANGELOG entry
@willemdh
Copy link

willemdh commented Apr 2, 2020

@ycombinator Hello, I just want to stress that this a bug with a huge impact. As the audit logs are enormous, the result is the clusters receiving these logs are not able to parse the timestamp which results in very heavy load and all kinds of issues.

ycombinator added a commit that referenced this pull request Apr 3, 2020
)

* Add pattern to handle logs from newer ES versions (#17406)

* Add pattern to handle logs from newer ES versions

* Adding CHANGELOG entry

* Removing fields not available in 7.6
ycombinator added a commit that referenced this pull request Apr 3, 2020
* Add pattern to handle logs from newer ES versions

* Adding CHANGELOG entry
ycombinator added a commit that referenced this pull request Apr 3, 2020
* Add pattern to handle logs from newer ES versions

* Adding CHANGELOG entry
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…astic#17422)

* Add pattern to handle logs from newer ES versions

* Adding CHANGELOG entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants