Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process.command_line to Sysmon module #17823

Merged
merged 3 commits into from
May 4, 2020

Conversation

andrewkroh
Copy link
Member

What does this PR do?

This is a continuation of #17327. The source fork no longer exists.

This add process.command_line and process.parent.command_line to Sysmon Event ID 1.

Why is it important?

The command_line is an ECS field.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@andrewkroh andrewkroh changed the title Webhead404 master Add process.command_line to Sysmon module Apr 20, 2020
webhead404 and others added 2 commits May 1, 2020 22:49
Adds the process.command_line field to Sysmon module that does not split the field into multiple values.
Handle the parent process.
Update golden files
Add changelog
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 63
Skipped 0
Total 63

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh merged commit 6473a6e into elastic:master May 4, 2020
@andrewkroh andrewkroh added the needs_backport PR is waiting to be backported to other branches. label May 4, 2020
andrewkroh added a commit to andrewkroh/beats that referenced this pull request May 4, 2020
* Add process.command_line to Sysmon module

Adds the process.command_line field to Sysmon module that does not split the field into multiple values.

* Handle process.parent.command_line

Handle the parent process.
Update golden files

Co-authored-by: webhead404 <kvvincentvalentine@gmail.com>
(cherry picked from commit 6473a6e)
@andrewkroh andrewkroh added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 4, 2020
andrewkroh added a commit that referenced this pull request May 4, 2020
* Add process.command_line to Sysmon module

Adds the process.command_line field to Sysmon module that does not split the field into multiple values.

* Handle process.parent.command_line

Handle the parent process.
Update golden files

Co-authored-by: webhead404 <kvvincentvalentine@gmail.com>
(cherry picked from commit 6473a6e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants