Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #17673 to 7.x: Add domain state to kvm module #18052

Merged
merged 2 commits into from
May 5, 2020
Merged

Cherry-pick #17673 to 7.x: Add domain state to kvm module #18052

merged 2 commits into from
May 5, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Apr 28, 2020 •
edited
Loading

Cherry-pick of PR #17673 to 7.x branch. Original message:

Signed-off-by: Tom Doherty tom@singlesecond.com

What does this PR do?

This change add's the domain state to the kvm metricbeat module.

Why is it important?

This allows tracking KVM transitions and consolidate resource usage with machine state

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

N/A

How to test this PR locally

I run this using sudo ./metricbeat test modules

Related issues

N/A

Use cases

Allows marrying resource and machine state metrics
Allows monitoring of KVM crashes or events via elastalert

Screenshots

N/A

Logs

N/A

Co-Authored-By: Tom Doherty tom@singlesecond.com

@tomdoherty @jsoriano
Add domain state metricset to kvm module (elastic#17673)
b38a78f 
This allows tracking KVM transitions of state and consolidate
resource usage with machine state.

Signed-off-by: Tom Doherty <tom@singlesecond.com>
(cherry picked from commit ed7fa2a)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 28, 2020
@jsoriano jsoriano self-assigned this Apr 28, 2020
@jsoriano
Copy link
Member Author

jenkins run the tests please

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 29, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

  • Build Cause: [Started by user Jaime Soriano Pastor, Replayed Random Crashes #6]

  • Start Time: 2020-05-04T07:51:20.160+0000

  • Duration: 74 min 14 sec (4454191)

  • Commit: b38a78f

Test stats 🧪

Test Results
Failed 0
Passed 2309
Skipped 572
Total 2881

@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 2, 2020
@elasticmachine
Copy link
Collaborator

💔 Build Failed

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 1
Passed 2152
Skipped 522
Total 2675

Test errors

Expand to view the tests failures

  • Name: Build and Test / Metricbeat OSS Integration tests / TestFetch – stat

    • Status: FAILED
    • Age: 1
    • Duration: 9.65
    • Error Details: Failed

Steps errors

Expand to view the steps failures

  • Name: Mage goIntegTest

    • Description: mage goIntegTest

    • Result: FAILURE

    • Duration: 39 min 41 sec<

    • Start Time: 2020-05-04T21:24:42.354+0000

Log output

Expand to view the last 100 lines of log output 

[2020-05-04T22:05:35.151Z] [success] 4.08% test_statsd.Test.test_server: 5.6226s
[2020-05-04T22:05:35.151Z] [success] 3.89% test_activemq.ActiveMqTest_0.test_broker_metrics_collected: 5.3547s
[2020-05-04T22:05:35.151Z] [success] 2.77% test_cockroachdb.Test.test_status: 3.8123s
[2020-05-04T22:05:35.151Z] [success] 1.98% test_xpack_base.Test.test_migration: 2.7256s
[2020-05-04T22:05:35.151Z] [success] 1.62% test_sql.Test.test_query: 2.2345s
[2020-05-04T22:05:35.151Z] [success] 1.51% test_xpack_base.Test.test_template: 2.0827s
[2020-05-04T22:05:35.151Z] [success] 1.48% test_openmetrics.Test.test_openmetrics: 2.0342s
[2020-05-04T22:05:35.151Z] [success] 1.19% test_appsearch.Test.test_stats: 1.6360s
[2020-05-04T22:05:35.151Z] [success] 1.09% test_stan.TestStan.test_metricset_2_subscriptions: 1.5003s
[2020-05-04T22:05:35.151Z] [success] 1.07% test_stan.TestStan.test_metricset_1_channels: 1.4671s
[2020-05-04T22:05:35.151Z] [success] 1.00% test_ibmmq.Test.test_qmgr: 1.3724s
[2020-05-04T22:05:35.151Z] [success] 0.86% test_stan.TestStan.test_metricset_0_stats: 1.1772s
[2020-05-04T22:05:35.151Z] [success] 0.79% test_redisenterprise.Test_0.test_metricset_1_proxy: 1.0882s
[2020-05-04T22:05:35.151Z] [success] 0.78% test_redisenterprise.Test_0.test_metricset_0_node: 1.0707s
[2020-05-04T22:05:35.151Z] [success] 0.73% test_xpack_base.Test.test_start_stop: 1.0054s
[2020-05-04T22:05:35.151Z] [success] 0.67% test_coredns.Test.test_stats: 0.9281s
[2020-05-04T22:05:35.151Z] [success] 0.62% test_activemq.ActiveMqTest_1.test_topic_metrics_collected: 0.8510s
[2020-05-04T22:05:35.151Z] [success] 0.59% test_mssql.Test.test_status: 0.8054s
[2020-05-04T22:05:35.151Z] [success] 0.57% test_activemq.ActiveMqTest_1.test_broker_metrics_collected: 0.7871s
[2020-05-04T22:05:35.151Z] [success] 0.56% test_activemq.ActiveMqTest_1.test_queue_metrics_collected: 0.7707s
[2020-05-04T22:05:35.151Z] [success] 0.55% test_mssql.Test.test_performance: 0.7503s
[2020-05-04T22:05:35.151Z] [success] 0.54% test_activemq.ActiveMqTest_0.test_topic_metrics_collected: 0.7412s
[2020-05-04T22:05:35.151Z] ----------------------------------------------------------------------
[2020-05-04T22:05:35.151Z] Ran 24 tests in 612.111s
[2020-05-04T22:05:35.151Z] 
[2020-05-04T22:05:35.151Z] OK
[2020-05-04T22:05:35.151Z] >> python test: Integration Testing Complete
[2020-05-04T22:05:36.513Z] Recording test results
[2020-05-04T22:06:04.953Z] Stashed 16 file(s)
[2020-05-04T22:06:05.016Z] Archiving artifacts
[2020-05-04T22:06:06.430Z] + curl -sSLo codecov https://codecov.io/bash
[2020-05-04T22:06:06.431Z] + FILE=auditbeat/build/coverage/full.cov
[2020-05-04T22:06:06.431Z] + [ -f auditbeat/build/coverage/full.cov ]
[2020-05-04T22:06:06.431Z] + FILE=filebeat/build/coverage/full.cov
[2020-05-04T22:06:06.431Z] + [ -f filebeat/build/coverage/full.cov ]
[2020-05-04T22:06:06.431Z] + FILE=heartbeat/build/coverage/full.cov
[2020-05-04T22:06:06.431Z] + [ -f heartbeat/build/coverage/full.cov ]
[2020-05-04T22:06:06.431Z] + FILE=libbeat/build/coverage/full.cov
[2020-05-04T22:06:06.431Z] + [ -f libbeat/build/coverage/full.cov ]
[2020-05-04T22:06:06.431Z] + FILE=metricbeat/build/coverage/full.cov
[2020-05-04T22:06:06.431Z] + [ -f metricbeat/build/coverage/full.cov ]
[2020-05-04T22:06:06.431Z] + FILE=packetbeat/build/coverage/full.cov
[2020-05-04T22:06:06.431Z] + [ -f packetbeat/build/coverage/full.cov ]
[2020-05-04T22:06:06.431Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-05-04T22:06:06.431Z] + [ -f winlogbeat/build/coverage/full.cov ]
[2020-05-04T22:06:06.431Z] + FILE=journalbeat/build/coverage/full.cov
[2020-05-04T22:06:06.431Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-05-04T22:06:08.788Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052/src/github.com/elastic/beats
[2020-05-04T22:06:09.471Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-05-04T22:06:09.587Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052/src/github.com/elastic/beats/Lint
[2020-05-04T22:06:09.834Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052/src/github.com/elastic/beats/Metricbeat-Windows
[2020-05-04T22:06:10.079Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-05-04T22:06:10.324Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-05-04T22:06:10.573Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052/src/github.com/elastic/beats/Metricbeat-Python-integration-tests
[2020-05-04T22:06:10.851Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests
[2020-05-04T22:06:11.111Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-05-04T22:06:12.234Z] + cat
[2020-05-04T22:06:12.234Z] + /usr/local/bin/runbld ./runbld-script
[2020-05-04T22:06:12.234Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-05-04T22:06:18.746Z] runbld>>> runbld started
[2020-05-04T22:06:18.746Z] runbld>>> 1.6.11/a66728ff8f4356963772e6e6d2069392fa06acbe
[2020-05-04T22:06:20.068Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-18052' in order of occurrence in the config (last value wins).
[2020-05-04T22:06:21.529Z] runbld>>> Debug logging enabled.
[2020-05-04T22:06:21.529Z] runbld>>> Storing result
[2020-05-04T22:06:21.966Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-05-04T22:06:21.966Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200504220621-FD541299
[2020-05-04T22:06:21.966Z] runbld>>> Adding system facts.
[2020-05-04T22:06:22.913Z] runbld>>> Adding vcs info for the latest commit:  648a6e72b775dc163ffee6972fc030726292e596
[2020-05-04T22:06:22.913Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-05-04T22:06:22.913Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-05-04T22:06:22.913Z] Processing JUnit reports with runbld...
[2020-05-04T22:06:22.913Z] + echo 'Processing JUnit reports with runbld...'
[2020-05-04T22:06:23.286Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-05-04T22:06:23.286Z] runbld>>> DURATION: 12ms
[2020-05-04T22:06:23.286Z] runbld>>> STDOUT: 40 bytes
[2020-05-04T22:06:23.287Z] runbld>>> STDERR: 49 bytes
[2020-05-04T22:06:23.287Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-05-04T22:06:23.287Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052/src/github.com/elastic/beats
[2020-05-04T22:06:24.672Z] runbld>>> Storing build metadata: 
[2020-05-04T22:06:24.672Z] runbld>>> Adding test report.
[2020-05-04T22:06:24.672Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052/src/github.com/elastic/beats
[2020-05-04T22:06:25.554Z] runbld>>> Found 52 test output files
[2020-05-04T22:06:25.554Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-05-04T22:06:25.554Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-05-04T22:06:25.932Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-05-04T22:06:26.318Z] runbld>>> Test output logs contained: Errors: 0 Failures: 1 Tests: 2675 Skipped: 391
[2020-05-04T22:06:26.717Z] runbld>>> Storing result
[2020-05-04T22:06:26.717Z] runbld>>> FAILURES: 1
[2020-05-04T22:06:27.097Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-05-04T22:06:27.097Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200504220621-FD541299
[2020-05-04T22:06:27.097Z] runbld>>> Email notification disabled by environment variable.
[2020-05-04T22:06:27.097Z] runbld>>> Slack notification disabled by environment variable.
[2020-05-04T22:06:34.341Z] Running on worker-395930 in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18052
[2020-05-04T22:06:34.941Z] [INFO] getVaultSecret: Getting secrets
[2020-05-04T22:06:35.107Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-04T22:06:38.114Z] + chmod 755 generate-build-data.sh
[2020-05-04T22:06:38.114Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18052/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18052/runs/8 FAILURE 5528358
[2020-05-04T22:06:38.114Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18052/runs/8/steps/?limit=10000 -o steps-info.json
[2020-05-04T22:06:39.049Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18052/runs/8/tests/?status=FAILED -o tests-errors.json
[2020-05-04T22:06:39.969Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18052/runs/8/log/ -o pipeline-log.txt

@jsoriano jsoriano merged commit 6a2e82e into elastic:7.x May 5, 2020
@jsoriano jsoriano deleted the backport_17673_7.x branch May 5, 2020 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@jsoriano jsoriano

Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsoriano @elasticmachine @kaiyan-sheng @andresrc @tomdoherty