Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17982 to 7.x: [Filebeat] Improve ECS field mappings in santa module #18114

Merged
merged 2 commits into from
May 5, 2020

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Apr 29, 2020

Cherry-pick of PR #17982 to 7.x branch. Original message:

What does this PR do?

Improves ECS field mappings in santa module. Specifically:

  • move certificate.common_name to santa.certificate.common_name (breaking change)
  • move certificate.sha256 to santa.certificate.sha256 (breaking change)
  • move hash.sha256 to process.hash.sha256 (breaking change)
  • event.action
  • event.category
  • event.kind
  • event.type
  • event.outcome
  • log.level
  • add full path to executable to process.args
  • related.hash
  • related.user

Why is it important?

Improved ECS compatibility improves the usefulness of the data in the SIEM app and makes cross correlation between data sources easier.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

GENERATE=true TESTING_FILEBEAT_MODULES=santa mage -v pythonIntegTest

Related issues

Closes #16180

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 29, 2020
* Improve ECS field mappings in santa module

- move certificate.common_name to
  santa.certificate.common_name (breaking change)
- move certificate.sha256 to
  santa.certificate.sha256 (breaking change)
- move hash.sha256 to process.hash.sha256 (breaking change)
- event.action
- event.category
- event.kind
- event.type
- event.outcome
- log.level
- add full path to executable to process.args
- related.hash
- related.user
- Add new default file path

Closes elastic#16180

(cherry picked from commit 81dfe61)
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 29, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 2108
Skipped 283
Total 2391

@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@leehinman leehinman merged commit 71d4714 into elastic:7.x May 5, 2020
@leehinman leehinman deleted the backport_17982_7.x branch May 5, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants