Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #18524 to 7.8: [Metricbeat] Fix tags_filter for cloudwatch metricset in aws module #18617

Merged
merged 1 commit into from
May 18, 2020
Merged

Cherry-pick #18524 to 7.8: [Metricbeat] Fix tags_filter for cloudwatch metricset in aws module #18617

merged 1 commit into from
May 18, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented May 18, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #18524 to 7.8 branch. Original message:

What does this PR do?

This PR is to fix tags_filter for cloudwatch metricset. Without this fix, when user tries to specify tags_filter in aws module config, it does not apply the filter on what events to send to ES.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kaiyan-sheng
[Metricbeat] Fix tags_filter for cloudwatch metricset in aws module (#…
025c24d 
…18524)

* Fix tags_filter for cloudwatch metricset
* if tags_filter is given, overwrite tags in cloudwatch specific config

(cherry picked from commit 5aa3d0c)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 18, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this May 18, 2020
@kaiyan-sheng kaiyan-sheng added Team:Platforms Label for the Integrations - Platforms team and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 591
Skipped 61
Total 652

@kaiyan-sheng kaiyan-sheng merged commit 67c6561 into elastic:7.8 May 18, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_18524_7.8 branch May 18, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
backport review Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @ChrsMark