Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Fix install service script for windows #18814

Merged
merged 3 commits into from
May 29, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented May 28, 2020

What does this PR do?

Agent was using beat version of install service script for windows but the way how agent is started is different.
This PR aligns script with the agent command syntax

Why is it important?

To enable agent be installed on windows as a service

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes: #18811

@michalpristas michalpristas added bug review needs_backport PR is waiting to be backported to other branches. Team:Ingest Management Ingest Management:alpha1 Group issues for ingest management alpha1 labels May 28, 2020
@michalpristas michalpristas self-assigned this May 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 28, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 28, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18814 updated]

  • Start Time: 2020-05-28T13:06:46.740+0000

  • Duration: 78 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 9242
Skipped 1542
Total 10784

@ph ph requested a review from andrewkroh May 28, 2020 12:14
@ph
Copy link
Contributor

ph commented May 28, 2020

@andrewkroh Could you take a look at this?

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In theory this would work for the Beats too since (IIRC) they actually have run as their default sub command.

@michalpristas michalpristas merged commit 36c3856 into elastic:master May 29, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request May 29, 2020
[Ingest Manager] Fix install service script for windows (elastic#18814)
michalpristas added a commit to michalpristas/beats that referenced this pull request May 29, 2020
[Ingest Manager] Fix install service script for windows (elastic#18814)
michalpristas added a commit that referenced this pull request May 29, 2020
)

[Ingest Manager] Fix install service script for windows (#18814)
michalpristas added a commit that referenced this pull request May 29, 2020
)

[Ingest Manager] Fix install service script for windows (#18814)
v1v added a commit to v1v/beats that referenced this pull request Jun 2, 2020
…-stage-level

* upstream/master: (30 commits)
  Add a GRPC listener service for Agent (elastic#18827)
  Disable host.* fields by default for iptables module (elastic#18756)
  [WIP] Clarify capabilities of the Filebeat auditd module (elastic#17068)
  fix: rename file and remove extra separator (elastic#18881)
  ci: enable JJBB (elastic#18812)
  Disable host.* fields by default for Checkpoint module (elastic#18754)
  Disable host.* fields by default for Cisco module (elastic#18753)
  Update latest.yml testing env to 7.7.0 (elastic#18535)
  Upgrade k8s.io/client-go and k8s keystore tests (elastic#18817)
  Add missing Jenkins stages for Auditbeat (elastic#18835)
  [Elastic Log Driver] Create a config shim between libbeat and the user (elastic#18605)
  Use indexers and matchers in config when defaults are enabled (elastic#18818)
  Fix panic on `metricbeat test modules` (elastic#18797)
  [CI] Fix permissions in MacOSX agents (elastic#18847)
  [Ingest Manager] When not port are specified and the https is used fallback to 443 (elastic#18844)
  [Ingest Manager] Fix install service script for windows (elastic#18814)
  [Metricbeat] Fix getting compute instance metadata with partial zone/region config (elastic#18757)
  Improve error messages in s3 input (elastic#18824)
  Add memory metrics into compute googlecloud (elastic#18802)
  include bucket name when logging error (elastic#18679)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Ingest Management:alpha1 Group issues for ingest management alpha1 needs_backport PR is waiting to be backported to other branches. review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ingest Manager] Fix start script for windows service
4 participants