Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix winlogbeat powershell event processing. #18966

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jun 4, 2020

What does this PR do?

Adds a function to dynamically calculate the number of chunks the dissect needs to parse for Powershell events.

It also improves the provided dashboard to show more information on the detail area.

Why is it important?

Powershell events carry a fixed amount of parameters. Seems to be that for downgraded events the number of parameters varies, so dissect failed for those.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    I have made corresponding changes to the documentation
    I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Screenshots

The updated dashboard

kibana-powershell

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 4, 2020
@marc-gr marc-gr force-pushed the fix_winlogbeat_powershell-downgrade branch from 98a056e to a151a0b Compare June 4, 2020 10:34
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 4, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18966 updated]

  • Start Time: 2020-06-04T15:23:08.973+0000

  • Duration: 45 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 780
Skipped 128
Total 908

Fix event processing for different engine versions.
Improve powershell dashboard
@marc-gr marc-gr force-pushed the fix_winlogbeat_powershell-downgrade branch from a151a0b to a953747 Compare June 4, 2020 15:22
@marc-gr marc-gr requested a review from leehinman June 4, 2020 15:26
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit d5fee98 into elastic:master Jun 5, 2020
@marc-gr marc-gr deleted the fix_winlogbeat_powershell-downgrade branch June 5, 2020 06:44
marc-gr added a commit to marc-gr/beats that referenced this pull request Jun 5, 2020
Fix winlogbeat powershell event processing.
- Fix event processing for different engine versions.
- Improve powershell dashboard

(cherry picked from commit d5fee98)
marc-gr added a commit that referenced this pull request Jun 5, 2020
Fix winlogbeat powershell event processing.
- Fix event processing for different engine versions.
- Improve powershell dashboard

(cherry picked from commit d5fee98)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
Fix winlogbeat powershell event processing.
- Fix event processing for different engine versions.
- Improve powershell dashboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants