Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19221 to 7.8: [Metricbeat] Remove dedot for AWS tag value #19251

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Cherry-pick #19221 to 7.8: [Metricbeat] Remove dedot for AWS tag value #19251

merged 2 commits into from
Jun 18, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jun 17, 2020

Cherry-pick of PR #19221 to 7.8 branch. Original message:

What does this PR do?

This PR is to remove dedotting when collecting AWS tag value. Only tag keys are dedotted, but keep tag values to be the original.

Why is it important?

For some use cases, tags value may contain dot, such as IPv4 address. There is no need to dedot when storing into ES in json event field value.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Screenshots

This is before and after comparison for tag value:
Screen Shot 2020-06-16 at 11 00 22 AM

* Remove dedot for AWS tag value

(cherry picked from commit e491c8d)
@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Jun 17, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 17, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 17, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19251 opened]

  • Start Time: 2020-06-17T15:53:04.664+0000

  • Duration: 61 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 482
Skipped 48
Total 530

@kaiyan-sheng kaiyan-sheng merged commit 30d1760 into elastic:7.8 Jun 18, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_19221_7.8 branch June 18, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team [zube]: Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants