Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Change comment trigger detection method #19827

Merged
merged 7 commits into from
Jul 14, 2020
Merged

ci: Change comment trigger detection method #19827

merged 7 commits into from
Jul 14, 2020

Conversation

kuisathaverat
Copy link
Contributor

@kuisathaverat kuisathaverat commented Jul 13, 2020 •
edited
Loading

What does this PR do?

It changes the filter for comment trigger.

Why is it important?

isCommentTrigger needs a node to works because we use it on a when context without a node provisioned it does not work, thus we changed that function to a triggerBy directive.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 13, 2020
@kuisathaverat
Copy link
Contributor Author

/package

@kuisathaverat kuisathaverat added the Team:Automation Label for the Observability productivity team label Jul 13, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 13, 2020
@kuisathaverat
Copy link
Contributor Author

/package

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 13, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19827 updated]

  • Start Time: 2020-07-13T17:15:59.058+0000

  • Duration: 21 min 28 sec

@kuisathaverat
Copy link
Contributor Author

/package

2 similar comments
@v1v
Copy link
Member

v1v commented Jul 13, 2020

/package

@v1v
Copy link
Member

v1v commented Jul 13, 2020

/package

@kuisathaverat
Copy link
Contributor Author

/package

@kuisathaverat
Copy link
Contributor Author

/package

@kuisathaverat kuisathaverat requested a review from a team July 13, 2020 17:18
@kuisathaverat kuisathaverat self-assigned this Jul 13, 2020
@kuisathaverat kuisathaverat marked this pull request as ready for review July 13, 2020 17:18
@kuisathaverat kuisathaverat mentioned this pull request Jul 13, 2020
Closed
@kuisathaverat kuisathaverat changed the title test: check which trigger is enabled ci: Change comment trigger detection method Jul 13, 2020
v1v
v1v approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is /package comment an example? Otherwise it will be required to enable it in

beats/.ci/apm-beats-update.groovy

Line 29 in 133fb60

issueCommentTrigger('(?i).*/run\\s+(?:apm-beats-update\\W+)?.*')

.ci/packaging.groovy Outdated Show resolved Hide resolved
@kuisathaverat @v1v
Update .ci/packaging.groovy
7b6c25e 
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@kuisathaverat
Copy link
Contributor Author

@v1v /package is a message for the packaging job

beats/.ci/packaging.groovy

Line 27 in 7b6c25e

issueCommentTrigger('(?i)^\\/packag[ing|e]$')

@kuisathaverat kuisathaverat merged commit cb4854c into elastic:master Jul 14, 2020
@kuisathaverat kuisathaverat mentioned this pull request Jul 14, 2020
Merged
kuisathaverat added a commit to kuisathaverat/beats that referenced this pull request Jul 14, 2020
@kuisathaverat @v1v
ci: Change comment trigger detection method (elastic#19827)
7447dc5 
* test: check which trigger is enabled

* chore: merge master

* test: test a fix

* test: change the comment trigger detection method

* test: change the comment trigger detection method

* Update .ci/packaging.groovy

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
kuisathaverat added a commit to kuisathaverat/beats that referenced this pull request Jul 14, 2020
@kuisathaverat @v1v
ci: Change comment trigger detection method (elastic#19827)
84e34ea 
* test: check which trigger is enabled

* chore: merge master

* test: test a fix

* test: change the comment trigger detection method

* test: change the comment trigger detection method

* Update .ci/packaging.groovy

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@kuisathaverat kuisathaverat mentioned this pull request Jul 14, 2020
Merged
kuisathaverat added a commit to kuisathaverat/beats that referenced this pull request Jul 14, 2020
@kuisathaverat @v1v
ci: Change comment trigger detection method (elastic#19827)
0e2a47d 
* test: check which trigger is enabled

* chore: merge master

* test: test a fix

* test: change the comment trigger detection method

* test: change the comment trigger detection method

* Update .ci/packaging.groovy

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@kuisathaverat kuisathaverat mentioned this pull request Jul 14, 2020
Merged
kuisathaverat added a commit that referenced this pull request Jul 14, 2020
@kuisathaverat @v1v
ci: Change comment trigger detection method (#19827) (#19871)
878079d 
* test: check which trigger is enabled

* chore: merge master

* test: test a fix

* test: change the comment trigger detection method

* test: change the comment trigger detection method

* Update .ci/packaging.groovy

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
kuisathaverat added a commit that referenced this pull request Jul 14, 2020
@kuisathaverat @v1v
ci: Change comment trigger detection method (#19827) (#19872)
e953d6e 
* test: check which trigger is enabled

* chore: merge master

* test: test a fix

* test: change the comment trigger detection method

* test: change the comment trigger detection method

* Update .ci/packaging.groovy

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
kuisathaverat added a commit that referenced this pull request Jul 14, 2020
@kuisathaverat @v1v
ci: Change comment trigger detection method (#19827) (#19873)
e05c5ea 
* test: check which trigger is enabled

* chore: merge master

* test: test a fix

* test: change the comment trigger detection method

* test: change the comment trigger detection method

* Update .ci/packaging.groovy

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit to v1v/beats that referenced this pull request Jul 14, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-7-32
de92936 
* upstream/master: (25 commits)
  [Elastic Agent] Send checkin payload to Fleet (elastic#19857)
  [Ingest Manager] Fixed tests across agent elastic#19877
  [Ingest Manager] Fix serialization test  elastic#19876
  Fix service start type mapping in windows/service metricset (elastic#19551)
  ci: Change comment trigger detection method (elastic#19827)
  Add 21 autogenerated filesets from rsa2elk devices (elastic#19713)
  [Ingest Manager] Agent config cleanup (elastic#19848)
  libbeat/publisher/pipeline: fix data races (elastic#19821)
  Update monitoring-internal-collection.asciidoc (elastic#19422) (elastic#19697)
  [Elastic Agent] Trust exchange endpoint must bind to 127.0.0.1 (elastic#19861)
  Specify an ECS version in Auditbeat/Packetbeat/Winlogbeat (elastic#19159)
  Add azure billing metricset (elastic#19207)
  Add support for appinsights in the metricbeat azure module (elastic#18940)
  Add MySQL query metricset with lightweight module and SQL helper (elastic#18955)
  [Ingest Manager] Refuse invalid stream values in configuration (elastic#19587)
  Do not use vendor during integration tests (elastic#19839)
  LIBBEAT: Enhancement Convert dissected values from String to other basic data types and IP (elastic#18683)
  [Elastic Agent] Remove support for "logs" and only support logfile (elastic#19761)
  [CI] support windows-2012 (elastic#19773)
  Do not update go.mod during packaging and testing (elastic#19823)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@kuisathaverat @v1v @melchiormoulin
ci: Change comment trigger detection method (elastic#19827)
6ee17e1 
* test: check which trigger is enabled

* chore: merge master

* test: test a fix

* test: change the comment trigger detection method

* test: change the comment trigger detection method

* Update .ci/packaging.groovy

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@kuisathaverat kuisathaverat deleted the test-filter branch December 24, 2020 11:07
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@kuisathaverat @v1v
ci: Change comment trigger detection method (elastic#19827) (elastic#…
687bc9e 
…19872)

* test: check which trigger is enabled

* chore: merge master

* test: test a fix

* test: change the comment trigger detection method

* test: change the comment trigger detection method

* Update .ci/packaging.groovy

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@kuisathaverat @v1v
ci: Change comment trigger detection method (elastic#19827) (elastic#…
5246f8e 
…19873)

* test: check which trigger is enabled

* chore: merge master

* test: test a fix

* test: change the comment trigger detection method

* test: change the comment trigger detection method

* Update .ci/packaging.groovy

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

@v1v v1v v1v approved these changes

Assignees

@kuisathaverat kuisathaverat

Labels
automation bug ci Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kuisathaverat @elasticmachine @v1v @mdelapenya