Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19483 to 7.x: [Filebeat][httpjson] Add date_cursor to httpjson input #19925

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jul 14, 2020

Cherry-pick of PR #19483 to 7.x branch. Original message:

What does this PR do?

Adds the ability to set a date_cursor in httpjson input. This can be used to make date based requests to the endpoint.

Why is it important?

To prevent requesting big amounts of events, or repeated events from APIs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Not sure if adding it to docs or not, since this is meant for very specific use cases for now.

* Add date_cursor to httpjson input

* Add changelog entry

* Fix tests

* Default to UTC date

* Add date_cursor validations and better error message

* Run fmt update

(cherry picked from commit 775f134)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants