-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Add backwards compatibility for append allow_duplicates #21159
Merged
marc-gr
merged 1 commit into
elastic:master
from
marc-gr:backwards_compat_allow_duplicates
Sep 21, 2020
Merged
[Filebeat] Add backwards compatibility for append allow_duplicates #21159
marc-gr
merged 1 commit into
elastic:master
from
marc-gr:backwards_compat_allow_duplicates
Sep 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Sep 18, 2020
marc-gr
force-pushed
the
backwards_compat_allow_duplicates
branch
from
September 18, 2020 09:02
1422b33
to
e8d96fb
Compare
Collaborator
leehinman
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andrewkroh
approved these changes
Sep 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍🏽
marc-gr
added a commit
to marc-gr/beats
that referenced
this pull request
Sep 21, 2020
(cherry picked from commit e51494f)
marc-gr
added a commit
that referenced
this pull request
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When loading a pipeline this change checks the elasticsearch version
and if the version is less than 7.10.0 it will replace the
"allow_duplicates: false" option with an equivalent if statement on the append
processor.
Why is it important?
This allows filebeat > 7.10.0 to be used with older versions of
elasticsearch. Without it the pipelines fail to load because the
option isn't supported.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.