Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Add backwards compatibility for append allow_duplicates #21159

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Sep 18, 2020

What does this PR do?

When loading a pipeline this change checks the elasticsearch version
and if the version is less than 7.10.0 it will replace the
"allow_duplicates: false" option with an equivalent if statement on the append
processor.

Why is it important?

This allows filebeat > 7.10.0 to be used with older versions of
elasticsearch. Without it the pipelines fail to load because the
option isn't supported.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 18, 2020
@marc-gr marc-gr added bug and removed enhancement labels Sep 18, 2020
@marc-gr marc-gr force-pushed the backwards_compat_allow_duplicates branch from 1422b33 to e8d96fb Compare September 18, 2020 09:02
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 18, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Marc Guasch, Replayed #2]

  • Start Time: 2020-09-18T10:40:13.017+0000

  • Duration: 55 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 5630
Skipped 825
Total 6455

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏽

@marc-gr marc-gr merged commit e51494f into elastic:master Sep 21, 2020
marc-gr added a commit to marc-gr/beats that referenced this pull request Sep 21, 2020
marc-gr added a commit that referenced this pull request Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants