Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badger build in 386 #21613

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Oct 7, 2020

What does this PR do?

Use correct int type to avoid overflows with 386 32-bit ints (elastic/badger@8b82801).

Why is it important?

Fixes builds in 386 systems.

Related issues

@jsoriano jsoriano added bug :Packaging Team:Platforms Label for the Integrations - Platforms team labels Oct 7, 2020
@jsoriano jsoriano self-assigned this Oct 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 7, 2020
@botelastic
Copy link

botelastic bot commented Oct 7, 2020

This pull request doesn't have a Team:<team> label.

@jsoriano
Copy link
Member Author

jsoriano commented Oct 7, 2020

/packaging

@jsoriano jsoriano added needs_backport PR is waiting to be backported to other branches. v7.10.0 v7.11.0 labels Oct 7, 2020
@jsoriano
Copy link
Member Author

jsoriano commented Oct 7, 2020

/package

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21613 opened]

  • Start Time: 2020-10-07T08:40:52.806+0000

  • Duration: 83 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 16296
Skipped 1347
Total 17643

@jsoriano jsoriano merged commit b58aeb6 into elastic:master Oct 7, 2020
@jsoriano jsoriano deleted the fix-badger-build-386 branch October 7, 2020 10:33
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Oct 7, 2020
jsoriano added a commit to jsoriano/beats that referenced this pull request Oct 7, 2020
Use a fork with the latest released version including the fix
for the issue with 32-bit architectures.
Fix uses uint32 instead of 32-bit int to avoid overflow in
constant with max uint32.

(cherry picked from commit b58aeb6)
jsoriano added a commit to jsoriano/beats that referenced this pull request Oct 7, 2020
Use a fork with the latest released version including the fix
for the issue with 32-bit architectures.
Fix uses uint32 instead of 32-bit int to avoid overflow in
constant with max uint32.

(cherry picked from commit b58aeb6)
jsoriano added a commit that referenced this pull request Oct 7, 2020
Use a fork with the latest released version including the fix
for the issue with 32-bit architectures.
Fix uses uint32 instead of 32-bit int to avoid overflow in
constant with max uint32.

(cherry picked from commit b58aeb6)
jsoriano added a commit that referenced this pull request Oct 7, 2020
Use a fork with the latest released version including the fix
for the issue with 32-bit architectures.
Fix uses uint32 instead of 32-bit int to avoid overflow in
constant with max uint32.

(cherry picked from commit b58aeb6)
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
…ci-build-label-support

* upstream/master: (60 commits)
  Skip publisher flaky tests (elastic#21657)
  backport: add 7.10 branch (elastic#21635)
  [CI: Packaging] fix: push ubi8 images too (elastic#21621)
  Docker build resiliance with a retry (elastic#21587)
  Fix flaky FSWatch/FSScanner tests (elastic#21625)
  chore: add versions 7.1x (elastic#21670)
  [Elastic Agent] Reload fleet.kibana.hosts from policy change (elastic#21599)
  Fix cyberark/corepas pipeline (elastic#21643)
  Add openstack ssl provider in add_cloud_metadata (elastic#21590)
  Add fips_enabled into all aws filesets (elastic#21626)
  [Filebeat S3] Change log.file.path to be nested object (elastic#21624)
  [CI] Change notification channel (elastic#21559)
  Add `add_observer_metadata` `geo.name` to Quickstart (elastic#21501)
  [E2E Tests] fix: set versions ony for PRs (elastic#21608)
  Fix badger build in 386 (elastic#21613)
  docs: Update timestamp.asciidoc (elastic#20395)
  Remove nil-zero metrics and linux-exclusive metrics from Metricbeat (elastic#21457)
  [Metricbeat] Use timestamp from CloudWatch for events (elastic#21498)
  [Filebeat][S3 Input] Add support for FIPS endpoints (elastic#21585)
  [Ingest Manager] Use new form of fleet API paths (elastic#21478)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
…012-2.0

* upstream/master: (110 commits)
  Skip publisher flaky tests (elastic#21657)
  backport: add 7.10 branch (elastic#21635)
  [CI: Packaging] fix: push ubi8 images too (elastic#21621)
  Docker build resiliance with a retry (elastic#21587)
  Fix flaky FSWatch/FSScanner tests (elastic#21625)
  chore: add versions 7.1x (elastic#21670)
  [Elastic Agent] Reload fleet.kibana.hosts from policy change (elastic#21599)
  Fix cyberark/corepas pipeline (elastic#21643)
  Add openstack ssl provider in add_cloud_metadata (elastic#21590)
  Add fips_enabled into all aws filesets (elastic#21626)
  [Filebeat S3] Change log.file.path to be nested object (elastic#21624)
  [CI] Change notification channel (elastic#21559)
  Add `add_observer_metadata` `geo.name` to Quickstart (elastic#21501)
  [E2E Tests] fix: set versions ony for PRs (elastic#21608)
  Fix badger build in 386 (elastic#21613)
  docs: Update timestamp.asciidoc (elastic#20395)
  Remove nil-zero metrics and linux-exclusive metrics from Metricbeat (elastic#21457)
  [Metricbeat] Use timestamp from CloudWatch for events (elastic#21498)
  [Filebeat][S3 Input] Add support for FIPS endpoints (elastic#21585)
  [Ingest Manager] Use new form of fleet API paths (elastic#21478)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug :Packaging Team:Platforms Label for the Integrations - Platforms team v7.10.0 v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dgraph cannot build for windows/i386
3 participants