Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Fix issue where inputs without processors defined would panic #21628

Merged
merged 3 commits into from
Oct 12, 2020

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Oct 7, 2020

What does this PR do?

Fixes issue where inputs without processors defined would panic when promoting processors from a dynamic provider.

Why is it important?

So using a dynamic provider on an input without any processors doesn't panic.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse self-assigned this Oct 7, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 7, 2020
@blakerouse blakerouse marked this pull request as ready for review October 7, 2020 12:46
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 7, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21628 updated]

  • Start Time: 2020-10-08T16:16:25.290+0000

  • Duration: 36 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 1390
Skipped 4
Total 1394

@ph ph added needs_backport PR is waiting to be backported to other branches. review labels Oct 7, 2020
@ph ph requested a review from michalpristas October 7, 2020 13:09
@michalpristas michalpristas added the Ingest Management:beta2 Group issues for ingest management beta2 label Oct 8, 2020
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakerouse blakerouse merged commit f3d18f9 into elastic:master Oct 12, 2020
@blakerouse blakerouse added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Oct 12, 2020
blakerouse added a commit to blakerouse/beats that referenced this pull request Oct 12, 2020
…ld panic (elastic#21628)

* Fix elastic#21581.

* Add changelog entry.

* Add test for processors as a map.

(cherry picked from commit f3d18f9)
blakerouse added a commit to blakerouse/beats that referenced this pull request Oct 12, 2020
…ld panic (elastic#21628)

* Fix elastic#21581.

* Add changelog entry.

* Add test for processors as a map.

(cherry picked from commit f3d18f9)
@blakerouse blakerouse deleted the fix-21581 branch October 12, 2020 14:07
v1v added a commit to v1v/beats that referenced this pull request Oct 13, 2020
* upstream/master: (127 commits)
  Update obs app links (elastic#21682)
  fix: update fleet test suite name (elastic#21738)
  Remove dot from file.extension value in Auditbeat FIM (elastic#21644)
  Fix leaks with metadata processors (elastic#16349)
  Add istiod metricset (elastic#21519)
  [Ingest Manager] Change Sync/Close call order (elastic#21735)
  [Ingest Manager] Syncing unpacked files (elastic#21706)
  Fix concurrent map read and write in socket dataset (elastic#21690)
  Fix conditional coding to remove seccomp info from Winlogbeat (elastic#21652)
  [Elastic Agent] Fix issue where inputs without processors defined would panic (elastic#21628)
  Add configuration of filestream input (elastic#21565)
  libbeat/logp: introduce Logger.WithOptions (elastic#21671)
  Make o365audit input cancellable (elastic#21647)
  fix: remove extra curly brace in script (elastic#21692)
  [Winlogbeat] Remove brittle configuration validation from wineventlog (elastic#21593)
  Fix function that parses from/to/contact headers (elastic#21672)
  [CI] Support Windows-2016 in pipeline 2.0 (elastic#21337)
  Skip publisher flaky tests (elastic#21657)
  backport: add 7.10 branch (elastic#21635)
  [CI: Packaging] fix: push ubi8 images too (elastic#21621)
  ...
blakerouse added a commit that referenced this pull request Oct 13, 2020
…ld panic (#21628) (#21716)

* Fix #21581.

* Add changelog entry.

* Add test for processors as a map.

(cherry picked from commit f3d18f9)
blakerouse added a commit that referenced this pull request Oct 13, 2020
…ld panic (#21628) (#21715)

* Fix #21581.

* Add changelog entry.

* Add test for processors as a map.

(cherry picked from commit f3d18f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingest Management:beta2 Group issues for ingest management beta2 review v7.10.0 v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when inspecting output when using dynamic providers
4 participants