[Ingest Manager] Use symlink path for reexecutions #21835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
bug
Team:Ingest Management
Ingest Management:beta2
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
needs_team
michalpristas
changed the title
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
Any issue linked to this? |
|
Any commentary on when this could potentially happen, sp we can improve test coverage? |
|
@EricDavisX updated description |
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Oct 22, 2020
[Ingest Manager] Use symlink path for reexecutions (elastic#21835)
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Oct 22, 2020
[Ingest Manager] Use symlink path for reexecutions (elastic#21835)
This was referenced Oct 22, 2020
michalpristas
added a commit
that referenced
this pull request
Oct 22, 2020
michalpristas
added a commit
that referenced
this pull request
Oct 22, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 26, 2020
…beats into feature/support-flaky-test-analyser * 'feature/support-flaky-test-analyser' of github.com:v1v/beats: (40 commits) [CI] support windows-10 (elastic#19804) Use default config when creating the input (elastic#22126) Change x509 mappings from file. to tls.server. (elastic#22097) Add fleet settings image (elastic#22065) Edit 7.9.3 changelog (elastic#22117) Edit 6.8.13 release notes (elastic#22120) Incorporate librpm fix feedback (elastic#22098) [libbeat] Add more disk queue unit tests and fix a size-check bug (elastic#22107) docs: move kerberos include (elastic#22109) Check context.Canceled and fix s3 input config (elastic#22036) Add max_number_of_messages into aws filebeat fileset vars (elastic#22057) Remove suricata.eve.timestamp alias (elastic#22095) [Ingest Manager] Use symlink path for reexecutions (elastic#21835) chore: use ubuntu 18 as linux agent (elastic#22084) docs: Prepare Changelog for 7.9.3 (elastic#22073) (elastic#22075) docs: Prepare Changelog for 6.8.13 (elastic#22072) (elastic#22079) [build][packaging] Add resilience when docker build (elastic#22050) Fix the url of reviewdog (elastic#21981) revert WSS process reporting for windows (elastic#22055) Fix typo (elastic#19585) (elastic#22061) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 26, 2020
…ter-commit * upstream/master: (25 commits) [CI] set env variable for the params (elastic#22143) Fix zeek connection pipeline (elastic#22151) Fix Google Cloud Function configuration file issues (elastic#22156) Remove old TODO on kubernetes node update (elastic#22074) [CI] Enable winlogbeat (elastic#22142) [CI] support windows-10 (elastic#19804) Use default config when creating the input (elastic#22126) Change x509 mappings from file. to tls.server. (elastic#22097) Add fleet settings image (elastic#22065) Edit 7.9.3 changelog (elastic#22117) Edit 6.8.13 release notes (elastic#22120) Incorporate librpm fix feedback (elastic#22098) [libbeat] Add more disk queue unit tests and fix a size-check bug (elastic#22107) docs: move kerberos include (elastic#22109) Check context.Canceled and fix s3 input config (elastic#22036) Add max_number_of_messages into aws filebeat fileset vars (elastic#22057) Remove suricata.eve.timestamp alias (elastic#22095) [Ingest Manager] Use symlink path for reexecutions (elastic#21835) chore: use ubuntu 18 as linux agent (elastic#22084) docs: Prepare Changelog for 7.9.3 (elastic#22073) (elastic#22075) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR initiates reexec manager with the path to symlink instead of
os.Executablewhich might point to actual executable even if executed using symlink. This behavior leads to reexecing into same binary/version even after upgrade is done.Tested on linux/windows.
This happens on some OSes as behavior differs in evaluating symlinks. Some refer to symlink file as a process executable some follow symlink and refer to an actual executable.
This is visible during upgrade when upgrade is successfully finished but after reboot it boots up same process (visible as version unchanged in fleet UI).
Why is it important?
Upgrade scenario
Fixes: #21935
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.