Azure storage metricset values not inside the metricset name #21845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
narph
added
[zube]: In Review
needs_backport
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
exekias
reviewed
Oct 16, 2020
| @@ -41,6 +41,8 @@ func New(base mb.BaseMetricSet) (mb.MetricSet, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| // set default resource type to indicate this is not the generic monitor metricset | |||
| ms.Client.Config.DefaultResourceType = defaultStorageAccountNamespace | |||
There was a problem hiding this comment.
is there any way we can test this?
There was a problem hiding this comment.
unless we change the entire structure of the function and create a mock client etc or having some integration tests in the future.
exekias
approved these changes
Oct 19, 2020
Merged
6 tasks
Merged
6 tasks
narph
added a commit
that referenced
this pull request
Oct 20, 2020
narph
added a commit
that referenced
this pull request
Oct 20, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 21, 2020
* upstream/master: feat: package aliases for snapshots (elastic#21960) [DOC] Add firewall as possible troubleshooting issue (elastic#21743) [Filebeat] Add max_number_of_messages config parameter for S3 input (elastic#21993) [Elastic Agent] Fix missing elastic_agent event data (elastic#21994) Document auditbeat system process module config (elastic#21766) Update links (elastic#22012) dynamically find librpm (elastic#21936) Fix Istio docs (elastic#22019) [beats-tester][packaging] store packages in another location (elastic#21903) [Kubernetes] Remove redundant dockersock volume mount (elastic#22009) [Ingest Manager] Always try snapshot repo for agent upgrade (elastic#21951) Azure storage metricset values not inside the metricset name (elastic#21845) fix diskio and memory bugs under windows (elastic#21992) Fix TestDockerStart flaky test (elastic#21681) filebeat: add SSL options to checkpoint module (elastic#19560) Stop storing stateless kubernetes keystores (elastic#21880) [Elastic Agent] Fix named pipe communication on Windows 7 (elastic#21931) [Elastic Agent] Fix index for Agent monitoring to to elastic_agent. (elastic#21932)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the azure storage metricset event format
Why is it important?
Latest changes on moving metricsets to light ones has caused on issue on the storage metricset where metric values were not inside the storage object
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.