Remove old TODO on kubernetes node update #22074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <chrismarkou92@gmail.com>
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
LGTM, do you have anything else pending in mind @vjsamuel ? |
|
No this has been addressed. Thank you for removing the todo. I somehow missed it. |
exekias
approved these changes
Oct 26, 2020
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Oct 26, 2020
(cherry picked from commit d36a510)
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Oct 26, 2020
(cherry picked from commit d36a510)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 26, 2020
…ter-commit * upstream/master: (25 commits) [CI] set env variable for the params (elastic#22143) Fix zeek connection pipeline (elastic#22151) Fix Google Cloud Function configuration file issues (elastic#22156) Remove old TODO on kubernetes node update (elastic#22074) [CI] Enable winlogbeat (elastic#22142) [CI] support windows-10 (elastic#19804) Use default config when creating the input (elastic#22126) Change x509 mappings from file. to tls.server. (elastic#22097) Add fleet settings image (elastic#22065) Edit 7.9.3 changelog (elastic#22117) Edit 6.8.13 release notes (elastic#22120) Incorporate librpm fix feedback (elastic#22098) [libbeat] Add more disk queue unit tests and fix a size-check bug (elastic#22107) docs: move kerberos include (elastic#22109) Check context.Canceled and fix s3 input config (elastic#22036) Add max_number_of_messages into aws filebeat fileset vars (elastic#22057) Remove suricata.eve.timestamp alias (elastic#22095) [Ingest Manager] Use symlink path for reexecutions (elastic#21835) chore: use ubuntu 18 as linux agent (elastic#22084) docs: Prepare Changelog for 7.9.3 (elastic#22073) (elastic#22075) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 27, 2020
…laky-test-analyser * upstream/master: Add new licence status: expired (elastic#22180) [filebeat][okta] Make cursor optional for okta and update docs (elastic#22091) Add documentation of filestream input (elastic#21615) [Ingest Manager] Skip flaky gateway tests elastic#22177 [CI] set env variable for the params (elastic#22143) Fix zeek connection pipeline (elastic#22151) Fix Google Cloud Function configuration file issues (elastic#22156) Remove old TODO on kubernetes node update (elastic#22074)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 27, 2020
…laky-test-analyser * upstream/master: Add new licence status: expired (elastic#22180) [filebeat][okta] Make cursor optional for okta and update docs (elastic#22091) Add documentation of filestream input (elastic#21615) [Ingest Manager] Skip flaky gateway tests elastic#22177 [CI] set env variable for the params (elastic#22143) Fix zeek connection pipeline (elastic#22151) Fix Google Cloud Function configuration file issues (elastic#22156) Remove old TODO on kubernetes node update (elastic#22074)
ChrsMark
added a commit
that referenced
this pull request
Oct 27, 2020
ChrsMark
added a commit
that referenced
this pull request
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@exekias @vjsamuel is this TODO
beats/libbeat/autodiscover/providers/kubernetes/node.go
Line 108 in bcb4e0c