Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Rename awscloudwatch input to aws-cloudwatch input #22228

Merged
merged 5 commits into from
Nov 10, 2020
Merged

[Filebeat] Rename awscloudwatch input to aws-cloudwatch input #22228

merged 5 commits into from
Nov 10, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 28, 2020 •
edited
Loading

What does this PR do?

This PR is to rename awscloudwatch input to aws-cloudwatch to follow the naming convention for Filebeat inputs.
After this PR get cherry-picked into 7.x, we can remove support of awscloudwatch. Or create a separate issue to remove old names in 8.0.

Deprecation warning log message is also added to this PR:

2020-10-28T12:41:21.556-0600    WARN    [aws-cloudwatch]        awscloudwatch/input.go:93       awscloudwatch input name is deprecated, please use aws-cloudwatch instead

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Make sure both awscloudwatch and aws-cloudwatch input work:

filebeat.inputs:
  - type: awscloudwatch
    credential_profile_name: elastic-beats
    log_group_arn: arn:aws:logs:us-east-1:428152502467:log-group:test:*
    region: us-east-1
    scan_frequency: 30s
    start_position: beginning
    api_timeout: 5m

and

filebeat.inputs:
  - type: aws-cloudwatch
    credential_profile_name: elastic-beats
    log_group_arn: arn:aws:logs:us-east-1:428152502467:log-group:test:*
    region: us-east-1
    scan_frequency: 30s
    start_position: beginning
    api_timeout: 5m

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 28, 2020
@kaiyan-sheng kaiyan-sheng mentioned this pull request Oct 28, 2020
Closed
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 28, 2020
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team labels Oct 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 28, 2020
@kaiyan-sheng kaiyan-sheng added the in progress Pull request is currently in progress. label Oct 28, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 28, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22228 updated]

  • Start Time: 2020-11-09T18:32:06.187+0000

  • Duration: 55 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 4475
Skipped 561
Total 5036

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 28, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 4475
Skipped 561
Total 5036

ChrsMark
ChrsMark approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kaiyan-sheng kaiyan-sheng merged commit 28ad00b into elastic:master Nov 10, 2020
@kaiyan-sheng kaiyan-sheng deleted the cloudwatch_input_rename branch November 10, 2020 17:25
@kaiyan-sheng kaiyan-sheng mentioned this pull request Nov 10, 2020
Merged
6 tasks
@kaiyan-sheng kaiyan-sheng added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Nov 10, 2020
kaiyan-sheng added a commit that referenced this pull request Nov 11, 2020
@kaiyan-sheng
[Filebeat] Rename awscloudwatch input to aws-cloudwatch input (#22228) (
d242a6d 
#22524)

* Rename awscloudwatch input to aws-cloudwatch input

* add deprecation warning message

(cherry picked from commit 28ad00b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
in progress Pull request is currently in progress. Team:Platforms Label for the Integrations - Platforms team v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @ChrsMark