Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Support Windows-8 #22307

Merged
merged 1 commit into from
Oct 30, 2020
Merged

[CI] Support Windows-8 #22307

merged 1 commit into from
Oct 30, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 30, 2020 •
edited
Loading

What does this PR do?

  • Add support for windows-8 in the CI

Status

Directory OS Mage Target Status CI
auditbeat windows-8 build unitTest 💚
filebeat windows-8 build unitTest 💚
heartbeat windows-8 build unitTest 💚
metricbeat windows-8 build unitTest 💚
packetbeat windows-8 build unitTest 💚
winlogBeat windows-8 build unitTest 💚
x-pack/auditbeat windows-8 build unitTest 💚
x-pack/elastic-agent windows-8 build unitTest 💚
x-pack/filebeat windows-8 build unitTest 💚
x-pack/functionbeat windows-8 build unitTest 💚
x-pack/metricbeat windows-8 build unitTest 💚
x-pack/packetbeat windows-8 build unitTest 💚
x-pack/winlogBeat windows-8 build unitTest 💚

@v1v v1v added automation Team:Automation Label for the Observability productivity team windows-8 Enable builds in the CI for windows-8 labels Oct 30, 2020
@v1v v1v self-assigned this Oct 30, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 30, 2020
@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16094
Skipped 1829
Total 17923

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22307 opened]

  • Start Time: 2020-10-30T13:15:47.876+0000

  • Duration: 75 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 16094
Skipped 1829
Total 17923

@v1v v1v requested review from andrewkroh and a team October 30, 2020 14:33
@v1v v1v marked this pull request as ready for review October 30, 2020 14:33
@v1v v1v requested review from a team as code owners October 30, 2020 14:33
@v1v v1v added the ci label Oct 30, 2020
mdelapenya
mdelapenya approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super readable!! 👏

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@v1v v1v merged commit 1900632 into elastic:master Oct 30, 2020
@v1v v1v deleted the feature/windows-8 branch October 30, 2020 15:48
v1v added a commit to v1v/beats that referenced this pull request Oct 30, 2020
@v1v
[CI] Support Windows-8 (elastic#22307)
cf9fd0e
@v1v v1v mentioned this pull request Oct 30, 2020
Merged
v1v added a commit to v1v/beats that referenced this pull request Oct 30, 2020
@v1v
[CI] Support Windows-8 (elastic#22307)
53a605c
@v1v v1v mentioned this pull request Oct 30, 2020
Merged
v1v added a commit to v1v/beats that referenced this pull request Oct 30, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-7-64
75dc72f 
* upstream/master:
  [JJBB] Add 6.8+ branches (elastic#22321)
  [CI] Support Windows-8 (elastic#22307)
  Change cloud.provider from googlecloud to gcp in billing metricset (elastic#22287)
  [packaging][beats-tester] use commit id binaries (elastic#22027)
  [CI] Report error in the catch section (elastic#22297)
v1v added a commit to v1v/beats that referenced this pull request Oct 30, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-7-32
6ab0f6c 
* upstream/master:
  [JJBB] Add 6.8+ branches (elastic#22321)
  [CI] Support Windows-8 (elastic#22307)
  Change cloud.provider from googlecloud to gcp in billing metricset (elastic#22287)
  [packaging][beats-tester] use commit id binaries (elastic#22027)
  [CI] Report error in the catch section (elastic#22297)
@andrewkroh
Copy link
Member

Is this Windows 8 or Windows 8.1? I assume 8.1 since 8 went EOL already.

@v1v
Copy link
Member Author

v1v commented Oct 31, 2020

Is this Windows 8 or Windows 8.1? I assume 8.1 since 8 went EOL already.

Probably the windows-8 is misleading, but as far as I see it's the name the infra team used for 8.1. I'll add a note in the issue that requested this particular windows support

v1v added a commit that referenced this pull request Nov 2, 2020
@v1v
[CI] Support Windows-8 (#22307) (#22318)
b82d12b
v1v added a commit that referenced this pull request Nov 2, 2020
@v1v
[CI] Support Windows-8 (#22307) (#22319)
5f9bed5
v1v added a commit to v1v/beats that referenced this pull request Nov 2, 2020
@v1v
Merge remote-tracking branch 'upstream/7.10' into backport/7.10/pr-19797
78fd4e2 
* upstream/7.10:
  [CI] Support Windows-8 (elastic#22307) (elastic#22319)
  Cherry-pick elastic#22152 to 7.10: Add interval documentation to `monitor` metricset (elastic#22294)
v1v added a commit to v1v/beats that referenced this pull request Nov 2, 2020
@v1v
Merge remote-tracking branch 'upstream/7.10' into backport/7.10/pr-19803
d19d642 
* upstream/7.10:
  [CI] Support Windows-8 (elastic#22307) (elastic#22319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

Assignees

@v1v v1v

Labels
automation ci Team:Automation Label for the Observability productivity team windows-8 Enable builds in the CI for windows-8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1v @elasticmachine @andrewkroh @mdelapenya