[filebeat][panw] Improve panos fileset url parsing #22481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
marc-gr
force-pushed
the
panos-url
branch
2 times, most recently
from
6d8957f
to
2814985
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
leehinman
requested changes
Nov 9, 2020
x-pack/filebeat/module/panw/panos/test/pan_inc_threat.log-expected.json
Outdated
Show resolved
Hide resolved
leehinman
reviewed
Nov 17, 2020
x-pack/filebeat/module/panw/panos/test/pan_inc_threat.log-expected.json
Outdated
Show resolved
Hide resolved
x-pack/filebeat/module/panw/panos/test/pan_inc_threat.log-expected.json
Outdated
Show resolved
Hide resolved
marc-gr
force-pushed
the
panos-url
branch
2 times, most recently
from
d126d80
to
96f7597
Compare
leehinman
approved these changes
Nov 18, 2020
3 tasks
marc-gr
added a commit
to marc-gr/beats
that referenced
this pull request
Nov 19, 2020
* Improve panos url parsing * Do not parse url details when not needed * Parse url based on threat subtype (cherry picked from commit bb973c4)
marc-gr
added a commit
that referenced
this pull request
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Parse panos url field to extract useful ecs fields.
Why is it important?
To improve ECS support in our modules.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentationCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.