[libbeat] Mark additional log metrics as gauges #22877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
review
libbeat
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
needs_team
andrewkroh
commented
Dec 2, 2020
| "beat.memstats.gc_next": true, | ||
| "beat.info.uptime.ms": true, | ||
| "beat.cpu.user.ticks": true, | ||
| "beat.cpu.user.time": true, |
There was a problem hiding this comment.
These metrics don't exist so I moved them. There are beat.cpu.*.time.ms metrics, but I don't see a problem with those being reported as delta (I assume the cpu times only ever increase).
`libbeat.output.events.active` and `beat.memstats.rss` are both gauges (rather than counters) so disable delta reporting for these two values.
andrewkroh
force-pushed
the
bugfix/libbeat/log-metric-guages
branch
from
0bbb839
to
fc09d86
Compare
andrewkroh
added
the
needs_backport
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
urso
approved these changes
Dec 7, 2020
2 tasks
andrewkroh
added
v7.11.0
and removed
needs_backport
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Dec 9, 2020
`libbeat.output.events.active` and `beat.memstats.rss` are both gauges (rather than counters) so disable delta reporting for these two values. (cherry picked from commit 547d15d)
andrewkroh
added a commit
that referenced
this pull request
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This marks additional log metrics as gauges.
libbeat.output.events.activeandbeat.memstats.rssare both gauges(rather than counters) so disable delta reporting for these two values.
Why is it important?
It's really hard to make sense the metrics over time since they are reported as deltas.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.