Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #23046 to 7.x: Add eTLD Handling in registered_domain Processor #23075

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Cherry-pick #23046 to 7.x: Add eTLD Handling in registered_domain Processor #23075

merged 2 commits into from
Dec 10, 2020

Conversation

andrewstucki
Copy link
Contributor

@andrewstucki andrewstucki commented Dec 10, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #23046 to 7.x branch. Original message:

What does this PR do?

This implements #23005.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Add eTLD Handling in registered_domain Processor (elastic#23046)
5ab2049 
* Add eTLD handling in registered_domain_processor

* Regenerate sysmon, zeek, and suricata golden files

* Add changelog entry

* Add empty string check

(cherry picked from commit e9d12e2)
@andrewstucki andrewstucki requested a review from a team as a code owner December 10, 2020 16:52
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 10, 2020
@andrewstucki andrewstucki requested a review from a team December 10, 2020 16:53
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 10, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Andrew Stucki

  • Start Time: 2020-12-10T17:53:19.586+0000

  • Duration: 56 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 17342
Skipped 1404
Total 18746

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17342
Skipped 1404
Total 18746

@andrewstucki andrewstucki merged commit ea7717b into elastic:7.x Dec 10, 2020
@andrewstucki andrewstucki deleted the backport_23046_7.x branch December 10, 2020 19:15
@zube zube bot removed the [zube]: Done label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewstucki @elasticmachine @leehinman