Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Processors] Add network direction processor #23076

Merged
merged 2 commits into from
Dec 10, 2020
Merged

[Processors] Add network direction processor #23076

merged 2 commits into from
Dec 10, 2020

Conversation

andrewstucki
Copy link
Contributor

@andrewstucki andrewstucki commented Dec 10, 2020 •
edited
Loading

What does this PR do?

This adds a network direction processor that handles network classification based on "perimeter-based" ECS values (inbound, outbound, internal, external).

This will allow us to add beats-side processing and direction classification of events when all you have is an event with two IP addresses.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewstucki andrewstucki requested a review from a team December 10, 2020 17:38
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 10, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 10, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23076 updated

  • Start Time: 2020-12-10T17:41:31.994+0000

  • Duration: 67 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 17405
Skipped 1379
Total 18784

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17405
Skipped 1379
Total 18784

leehinman
leehinman approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@andrewstucki andrewstucki merged commit f78a14c into elastic:master Dec 10, 2020
@andrewstucki andrewstucki deleted the network-direction-processor branch December 10, 2020 19:08
andrewstucki pushed a commit to andrewstucki/beats that referenced this pull request Dec 10, 2020
[Processors] Add network direction processor (elastic#23076)
e7cc8b9 
* Add network direction processor

* Add changelog entry

(cherry picked from commit f78a14c)
@andrewstucki andrewstucki mentioned this pull request Dec 10, 2020
Merged
6 tasks
andrewstucki pushed a commit that referenced this pull request Dec 10, 2020
[Processors] Add network direction processor (#23076) (#23079)
62467ea 
* Add network direction processor

* Add changelog entry

(cherry picked from commit f78a14c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
enhancement :Processors v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewstucki @elasticmachine @leehinman