Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23076 to 7.x: [Processors] Add network direction processor #23079

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

andrewstucki
Copy link
Contributor

@andrewstucki andrewstucki commented Dec 10, 2020

Cherry-pick of PR #23076 to 7.x branch. Original message:

What does this PR do?

This adds a network direction processor that handles network classification based on "perimeter-based" ECS values (inbound, outbound, internal, external).

This will allow us to add beats-side processing and direction classification of events when all you have is an event with two IP addresses.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

* Add network direction processor

* Add changelog entry

(cherry picked from commit f78a14c)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 10, 2020
@andrewstucki andrewstucki requested a review from a team December 10, 2020 19:11
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23079 opened

  • Start Time: 2020-12-10T19:10:09.510+0000

  • Duration: 74 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 17362
Skipped 1404
Total 18766

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 16 sec . View more details on here

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17362
Skipped 1404
Total 18766

@andrewstucki andrewstucki merged commit 62467ea into elastic:7.x Dec 10, 2020
@andrewstucki andrewstucki deleted the backport_23076_7.x branch December 10, 2020 20:25
@zube zube bot removed the [zube]: Done label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants