Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop @timestamp for juniper.junos system tests #23239

Merged

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Dec 22, 2020

What does this PR do?

Configure Filebeat system tests to drop @timestamp from juniper.junos golden files.

Why is it important?

Some autogenerated logs in juniper.junos contain timestamps without a year in them, meaning that once a year the extracted timestamp will be different.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@adriansr adriansr added review needs_backport PR is waiting to be backported to other branches. flaky-test Unstable or unreliable test cases. Team:Security-External Integrations labels Dec 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 22, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23239 opened

  • Start Time: 2020-12-22T09:01:21.936+0000

  • Duration: 33 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 2675
Skipped 311
Total 2986

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2675
Skipped 311
Total 2986

@marc-gr marc-gr merged commit cc8f870 into elastic:master Dec 22, 2020
@marc-gr marc-gr added v7.12.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 22, 2020
marc-gr pushed a commit to marc-gr/beats that referenced this pull request Dec 22, 2020
marc-gr pushed a commit to marc-gr/beats that referenced this pull request Dec 22, 2020
marc-gr added a commit that referenced this pull request Dec 22, 2020
(cherry picked from commit cc8f870)

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
marc-gr added a commit that referenced this pull request Dec 22, 2020
(cherry picked from commit cc8f870)

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Unstable or unreliable test cases. review v7.11.0 v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants