Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23215 to 7.11: [Filebeat] Add pubsub_alternative_host to gcp pubsub input #23245

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Dec 22, 2020

Cherry-pick of PR #23215 to 7.11 branch. Original message:

What does this PR do?

Adds an option to set a custom pubsub alternative host to pubsub input.

Why is it important?

To be able to start the input using the GCP Pubsub emulator we needed a way to configure it to point to our testing host and bypass credential initialization.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation (we do not want to document that as it is intended for testing)
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 22, 2020
@botelastic
Copy link

botelastic bot commented Dec 22, 2020

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 22, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23245 updated

  • Start Time: 2020-12-22T16:09:30.643+0000

  • Duration: 46 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 2436
Skipped 263
Total 2699

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2436
Skipped 263
Total 2699

…3215)

* Add pubsub_alternative_host to gcp pubsub input

* Apply suggestions

* Add changelog entry

* Add new option comment

* Make error more descriptive and reorder imports

(cherry picked from commit 545598f)
@marc-gr marc-gr merged commit 87e95a7 into elastic:7.11 Dec 22, 2020
@marc-gr marc-gr deleted the backport_23215_7.11 branch December 22, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants