Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #23490 to 7.11: Fix flaky tests for Metricbeat on Windows 2008 R2 #23508

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Cherry-pick #23490 to 7.11: Fix flaky tests for Metricbeat on Windows 2008 R2 #23508

merged 1 commit into from
Jan 15, 2021

Conversation

narph
Copy link
Contributor

@narph narph commented Jan 14, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #23490 to 7.11 branch. Original message:

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@narph
Fix flaky tests for Metricbeat on Windows 2008 R2 (elastic#23490)
9a58563 
* enable 2008

* [CI] Optional stage instead the mandatory one

windows stage is mandatory, but optional stages are not mandatory for PRs

Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com>
(cherry picked from commit 9283a6f)
@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Jan 14, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 14, 2021
@botelastic
Copy link

botelastic bot commented Jan 14, 2021

This pull request doesn't have a Team:<team> label.

@narph narph added the windows-2008 Enable builds in the CI for windows-2008 label Jan 14, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23508 opened

    • Start Time: 2021-01-14T11:24:11.114+0000

  • Duration: 44 min 54 sec

  • Commit: 9a58563

Test stats 🧪

Test Results
Failed 0
Passed 2840
Skipped 760
Total 3600

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2840
Skipped 760
Total 3600

@narph narph merged commit 3b9cf8b into elastic:7.11 Jan 15, 2021
@narph narph deleted the backport_23490_7.11 branch January 15, 2021 10:30
@zube zube bot removed the [zube]: Done label Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees
No one assigned
Labels
backport Team:Integrations Label for the Integrations team windows-2008 Enable builds in the CI for windows-2008
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @kaiyan-sheng