Add experimental symlink support #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, great that you got this in before beta1. Should have a changelog item. |
This implementation of symlinks takes a symlink and opens the original file. The only difference is that as Source the symlink path is reported. The advantage of this implementation is that everything related to file handling is identical with non symlink files as the original file is harvested. All close_* options work as expected. State information is stored for the original file, not the symlink itself. In case a symlink and original file are harvested, only one will be harvested as they share the same inode information. * Add test to verify that symlinks are disabled by default * Add test for symlink handling * Improve error handling in harvester. Return proper error messages instead of logging it. Prevents too many log messages. * Remove IsRegular file call as not needed anymore and leads to additional Stat calls * Add documentation See elastic#2277 and elastic#1767
2 tasks
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Sep 9, 2016
This bug was introduce with elastic#2478 . The check for the second Stat receiving was missing. In case of very fast rotating file it could be that exactly at the time of Stat request the file is not existing anymore and an error is returned. The error was not checked.
andrewkroh
pushed a commit
that referenced
this pull request
Sep 9, 2016
This bug was introduce with #2478 . The check for the second Stat receiving was missing. In case of very fast rotating file it could be that exactly at the time of Stat request the file is not existing anymore and an error is returned. The error was not checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2277 and #1767