Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[elastic-agent] Rename 'offline' image to 'complete' #27350

Merged
merged 3 commits into from
Aug 15, 2021
Merged

[elastic-agent] Rename 'offline' image to 'complete' #27350

merged 3 commits into from
Aug 15, 2021

Conversation

andrewvc
Copy link
Contributor

We've discussed internally that 'complete' is more appropriate than 'offline' in terms of naming for the new image. This makes that simple change.

@andrewvc
[elastic-agent] Rename 'offline' image to 'complete'
072f3bb 
We've discussed internally that 'complete' is more appropriate than
'offline' in terms of naming for the new image. This makes that simple
change.
@andrewvc andrewvc added enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team Agent v7.15.0 labels Aug 13, 2021
@andrewvc andrewvc self-assigned this Aug 13, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 13, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 13, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-15T02:44:04.496+0000

  • Duration: 219 min 33 sec

  • Commit: ff75472

Test stats 🧪

Test Results
Failed 0
Passed 53108
Skipped 5318
Total 58426

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 53108
Skipped 5318
Total 58426

vigneshshanmugam
vigneshshanmugam requested changes Aug 13, 2021
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes in this file - https://github.com/andrewvc/beats/blob/3fa0117008079b08c713a29b80c5ed36743fefcb/dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl#L32

@andrewvc
Copy link
Contributor Author

/test

@andrewvc
Copy link
Contributor Author

/test

@andrewvc
Copy link
Contributor Author

@elasticmachine merge upstream

vigneshshanmugam
vigneshshanmugam approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 14, 2021

Command update: success

Branch has been successfully updated

@andrewvc
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2021

Command update: success

Branch already up to date

@andrewvc
Copy link
Contributor Author

/test

@andrewvc andrewvc merged commit 84b4cea into elastic:master Aug 15, 2021
@andrewvc andrewvc deleted the offline-to-complete branch August 16, 2021 13:10
@andrewvc
Copy link
Contributor Author

@Mergifyio backport 7.x

@mergify mergify bot mentioned this pull request Aug 16, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2021

Command backport 7.x: success

Backports have been created

@andrewvc
Copy link
Contributor Author

@Mergifyio backport 7.x

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2021

Command backport 7.x: success

Backports have been created

andrewvc added a commit that referenced this pull request Aug 16, 2021
@andrewvc
[elastic-agent] Rename 'offline' image to 'complete' (#27350)
517379e
@cachedout cachedout mentioned this pull request Aug 17, 2021
Merged
6 tasks
cachedout pushed a commit that referenced this pull request Aug 18, 2021
@mergify @andrewvc
[elastic-agent] Rename 'offline' image to 'complete' (#27350) (#27395)
6f945ca 
Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@andrewvc andrewvc added the test-plan Add this PR to be manual test plan label Aug 18, 2021
This was referenced Aug 26, 2021
Closed
Closed
@mdelapenya mdelapenya mentioned this pull request Oct 19, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@andrewvc andrewvc

Labels
Agent enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team test-plan Add this PR to be manual test plan v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewvc @elasticmachine @vigneshshanmugam